Skip to content

Conversation

@mmat11
Copy link
Contributor

@mmat11 mmat11 commented Oct 29, 2025

Following #812, this PR adds support for AWS SQS spans: https://opentelemetry.io/docs/specs/semconv/messaging/sqs/

In addition, keep common AWS bits in one place and refactor the s3 code to use the common parts

Part of #141

@mmat11 mmat11 requested a review from a team as a code owner October 29, 2025 17:30
@codecov
Copy link

codecov bot commented Oct 29, 2025

Codecov Report

❌ Patch coverage is 37.86982% with 105 lines in your changes missing coverage. Please review.
✅ Project coverage is 55.35%. Comparing base (d06d978) to head (cd06ed3).
⚠️ Report is 3 commits behind head on main.

Files with missing lines Patch % Lines
pkg/appolly/app/request/span_getters.go 0.00% 27 Missing ⚠️
pkg/appolly/app/request/span.go 0.00% 20 Missing and 2 partials ⚠️
pkg/ebpf/common/http/aws_sqs.go 65.62% 15 Missing and 7 partials ⚠️
pkg/export/otel/tracesgen/tracesgen.go 0.00% 16 Missing and 1 partial ⚠️
pkg/appolly/app/request/metric_attributes.go 0.00% 8 Missing ⚠️
pkg/ebpf/common/http_transform.go 0.00% 5 Missing ⚠️
pkg/ebpf/common/http/aws_s3.go 42.85% 2 Missing and 2 partials ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #827      +/-   ##
==========================================
- Coverage   55.48%   55.35%   -0.13%     
==========================================
  Files         249      251       +2     
  Lines       21188    21319     +131     
==========================================
+ Hits        11757    11802      +45     
- Misses       8638     8713      +75     
- Partials      793      804      +11     
Flag Coverage Δ
integration-test 23.17% <0.00%> (-0.08%) ⬇️
integration-test-arm 0.00% <0.00%> (ø)
integration-test-vm-${ARCH}-${KERNEL_VERSION} ?
k8s-integration-test 2.78% <0.00%> (-0.02%) ⬇️
oats-test 0.00% <0.00%> (ø)
unittests 46.47% <37.86%> (-0.07%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Copy link
Contributor

@rafaelroquetto rafaelroquetto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Coolness!

Copy link
Contributor

@grcevski grcevski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One small comment about maybe getting a bounds error?

@grcevski grcevski merged commit 39e628f into open-telemetry:main Oct 30, 2025
44 checks passed
@grcevski
Copy link
Contributor

Great stuff!

@MrAlias MrAlias added this to the v0.1.0 milestone Oct 30, 2025
@mmat11 mmat11 deleted the matt/sqs branch November 3, 2025 19:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants