-
Notifications
You must be signed in to change notification settings - Fork 52
http: add support for AWS SQS spans #827
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## main #827 +/- ##
==========================================
- Coverage 55.48% 55.35% -0.13%
==========================================
Files 249 251 +2
Lines 21188 21319 +131
==========================================
+ Hits 11757 11802 +45
- Misses 8638 8713 +75
- Partials 793 804 +11
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Signed-off-by: Mattia Meleleo <[email protected]>
rafaelroquetto
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Coolness!
grcevski
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One small comment about maybe getting a bounds error?
|
Great stuff! |
Following #812, this PR adds support for AWS SQS spans: https://opentelemetry.io/docs/specs/semconv/messaging/sqs/
In addition, keep common AWS bits in one place and refactor the s3 code to use the common parts
Part of #141