Skip to content

Commit b56f585

Browse files
committed
refactor(otelhttp): change Version() func to const Version string
1 parent 79904a3 commit b56f585

File tree

5 files changed

+8
-9
lines changed

5 files changed

+8
-9
lines changed

instrumentation/net/http/otelhttp/common.go

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -23,5 +23,5 @@ const (
2323
type Filter func(*http.Request) bool
2424

2525
func newTracer(tp trace.TracerProvider) trace.Tracer {
26-
return tp.Tracer(ScopeName, trace.WithInstrumentationVersion(Version()))
26+
return tp.Tracer(ScopeName, trace.WithInstrumentationVersion(Version))
2727
}

instrumentation/net/http/otelhttp/config.go

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -67,7 +67,7 @@ func newConfig(opts ...Option) *config {
6767

6868
c.Meter = c.MeterProvider.Meter(
6969
ScopeName,
70-
metric.WithInstrumentationVersion(Version()),
70+
metric.WithInstrumentationVersion(Version),
7171
)
7272

7373
return c

instrumentation/net/http/otelhttp/handler_test.go

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -174,15 +174,15 @@ func TestHandlerBasics(t *testing.T) {
174174
func assertScopeMetrics(t *testing.T, sm metricdata.ScopeMetrics, attrs attribute.Set) {
175175
assert.Equal(t, instrumentation.Scope{
176176
Name: "go.opentelemetry.io/contrib/instrumentation/net/http/otelhttp",
177-
Version: Version(),
177+
Version: Version,
178178
}, sm.Scope)
179179

180180
require.Len(t, sm.Metrics, 3)
181181

182182
want := metricdata.ScopeMetrics{
183183
Scope: instrumentation.Scope{
184184
Name: ScopeName,
185-
Version: Version(),
185+
Version: Version,
186186
},
187187
Metrics: []metricdata.Metrics{
188188
{

instrumentation/net/http/otelhttp/transport_test.go

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -860,15 +860,15 @@ func TestTransportMetrics(t *testing.T) {
860860
func assertClientScopeMetrics(t *testing.T, sm metricdata.ScopeMetrics, attrs attribute.Set) {
861861
assert.Equal(t, instrumentation.Scope{
862862
Name: "go.opentelemetry.io/contrib/instrumentation/net/http/otelhttp",
863-
Version: Version(),
863+
Version: Version,
864864
}, sm.Scope)
865865

866866
require.Len(t, sm.Metrics, 2)
867867

868868
want := metricdata.ScopeMetrics{
869869
Scope: instrumentation.Scope{
870870
Name: ScopeName,
871-
Version: Version(),
871+
Version: Version,
872872
},
873873
Metrics: []metricdata.Metrics{
874874
{

instrumentation/net/http/otelhttp/version.go

Lines changed: 2 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -4,7 +4,6 @@
44
package otelhttp // import "go.opentelemetry.io/contrib/instrumentation/net/http/otelhttp"
55

66
// Version is the current release version of the otelhttp instrumentation.
7-
func Version() string {
8-
return "0.63.0"
7+
const Version = "0.63.0"
98
// This string is updated by the pre_release.sh script during release
10-
}
9+

0 commit comments

Comments
 (0)