Skip to content

Commit 460f303

Browse files
addressed review comment: use named return to make code more readable
1 parent 32b6f61 commit 460f303

File tree

1 file changed

+3
-7
lines changed

1 file changed

+3
-7
lines changed

exporters/stdout/stdoutmetric/exporter.go

Lines changed: 3 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -82,13 +82,12 @@ func (e *exporter) Aggregation(k metric.InstrumentKind) metric.Aggregation {
8282
return e.aggregationSelector(k)
8383
}
8484

85-
func (e *exporter) Export(ctx context.Context, data *metricdata.ResourceMetrics) error {
86-
var err error
85+
func (e *exporter) Export(ctx context.Context, data *metricdata.ResourceMetrics) (err error) {
8786
trackExportFunc := e.trackExport(context.Background(), countDataPoints(data))
8887
defer func() { trackExportFunc(err) }()
8988
err = ctx.Err()
9089
if err != nil {
91-
return err
90+
return
9291
}
9392
if e.redactTimestamps {
9493
redactTimestamps(data)
@@ -97,10 +96,7 @@ func (e *exporter) Export(ctx context.Context, data *metricdata.ResourceMetrics)
9796
global.Debug("STDOUT exporter export", "Data", data)
9897

9998
err = e.encVal.Load().(encoderHolder).Encode(data)
100-
if err != nil {
101-
return err
102-
}
103-
return nil
99+
return
104100
}
105101

106102
func (e *exporter) trackExport(ctx context.Context, count int64) func(err error) {

0 commit comments

Comments
 (0)