Expose addtional status for open telemetry collector #4479
Conversation
Signed-off-by: Praful Khanduri <[email protected]>
Signed-off-by: Praful Khanduri <[email protected]>
Signed-off-by: Praful Khanduri <[email protected]>
|
I’ve added some Todos and could use some help. Are any fields missing, or are all the necessary ones included? I’m happy to hear any suggestions. |
| - `LastInjectionTime`: Timestamp of the last successful sidecar injection | ||
| - `LastInjectionError`: Error message from the last failed sidecar injection | ||
| - `InjectionStatus`: Status of the sidecar injection process | ||
| - `ObservedGeneration`: Last observed generation of the OpenTelemetryCollector resource |
There was a problem hiding this comment.
isn't this already included somewhere in the CR?
There was a problem hiding this comment.
This is specifically for the sidecar for the spec fields , are you refering that injection-related fields LastInjectionTime, LastInjectionError, InjectionStatus probably be expressed through the Conditions? Or Redundant?
| } | ||
|
|
||
| // updateSidecarStatus gathers information about sidecar injection and updates the status fields. | ||
| func updateSidecarStatus(ctx context.Context, cli client.Client, otelcol *v1beta1.OpenTelemetryCollector) error { |
There was a problem hiding this comment.
Can you describe at a high level how the status is set?
It seems that the impl is getting a list of pods from the NS of the otelcol CR. I have two observations:
- the sidecar can be injected in a namespace that does not contain any otelcol CR
- is the reconciliation triggered when the pod is deleted?
There was a problem hiding this comment.
is the reconciliation triggered when the pod is deleted?
Oops i missed that
Signed-off-by: Praful Khanduri <[email protected]> updated bundle & docs Signed-off-by: Praful Khanduri <[email protected]>
2 participants
Description: Added additional status information fields for OpenTelemetryCollector sidecar injection.
Link to tracking Issue(s):
OpenTelemetryCollectorinmode: sidecar#4313Change Type: Enhancement
Component: Collector
Testing: Added unit tests; E2E pending.
Documentation: