Minor changes to basic-health-check: improve information level #271
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
frispete
commented
Sep 12, 2025
frispete
commented
- add free -h: customers tend to use systems with more and more RAM, free -k makes it increasingly hard to comprehend the amount, but keep free -k for machine based parsers of supportconfigs
- change df -h to df -hT: get immediate overview of the file systems in use with no additional cost. Since it is pretty hard to parse the df output already, we take to risk of breaking them
* add free -h: customers tend to use systems with more and more RAM, free -k makes it increasingly hard to comprehend the amount, but keep free -k for machine based parsers of supportconfigs * change df -h to df -hT: get immediate overview of the file systems in use with no additional cost. Since it is pretty hard to parse the df output already, we take to risk of breaking them
Collaborator
|
Both of these changes will affect the scatool and its libraries. I'll check what kind of changes or enhancements would be necessary for the scatool. |
Collaborator
|
fs-diskio.txt contains 'df -Th'. I acknowledge that basic-health.txt would be a logical fit for 'free -h' instead of 'free -k'. 'free -h' is no where else in supportconfig. |
Author
|
So, what do you want from me? Change something? Sure, fs-diskio.txt contains the same call already, but what harm it would do to inform the engineer right from the beginning about, which filesystems are in action here? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.