Skip to content

Commit 4428040

Browse files
author
AJ Keller
authored
Merge pull request #123 from OpenBCI/development
1.4.1
2 parents d4f62ef + f7e5c49 commit 4428040

11 files changed

+491
-223
lines changed

README.md

Lines changed: 4 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -28,7 +28,7 @@ The purpose of this module is to **get connected** and **start streaming** as fa
2828
4. [Constants](#constants)
2929
6. [Interfacing With Other Tools](#interfacing-with-other-tools)
3030
7. [Developing](#developing)
31-
8. [Testing](#testing)
31+
8. [Testing](#developing-testing)
3232
9. [Contribute](#contribute)
3333
10. [License](#license)
3434
11. [Roadmap](#roadmap)
@@ -846,7 +846,7 @@ To leave simulate mode.
846846
847847
### <a name="method-sntp"></a> .sntp
848848
849-
Extends the popular STNP package on [npmjs](https://www.npmjs.com/package/sntp)
849+
Extends the popular SNTP package on [npmjs](https://www.npmjs.com/package/sntp)
850850
851851
### <a name="method-sntp-get-offset"></a> .sntpGetOffset()
852852
@@ -1166,13 +1166,14 @@ npm test
11661166
## <a name="contribute"></a> Contribute:
11671167
11681168
1. Fork it!
1169+
2. Branch off of `development`: `git checkout development`
11691170
2. Create your feature branch: `git checkout -b my-new-feature`
11701171
3. Make changes
11711172
4. If adding a feature, please add test coverage.
11721173
5. Ensure tests all pass. (`npm test`)
11731174
6. Commit your changes: `git commit -m 'Add some feature'`
11741175
7. Push to the branch: `git push origin my-new-feature`
1175-
8. Submit a pull request :D
1176+
8. Submit a pull request. Make sure it is based off of the `development` branch when submitting! :D
11761177
11771178
## <a name="license"></a> License:
11781179

changelog.md

Lines changed: 7 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,3 +1,9 @@
1+
# 1.4.1
2+
3+
### Bug Fixes
4+
* Fixes bug where extra data after EOT (`$$$`) was dumped by preserving the poriton after the EOT for further decomposition.
5+
* Fixes bug where any calls to channel set would actually break the openBCISample code as the channelSettingsArray contained an undefined.
6+
17
# 1.4.0
28

39
### New Features
@@ -22,6 +28,7 @@
2228
* The `.streaming` property has been removed, replaced by `.isStreaming()`. Removed from docs.
2329
* An error event will be emitted if sntp fails to initialize on construction
2430
* The simulator will no longer communicate when disconnected
31+
* Promises returned by writes will now only resolve after the write has been sent
2532

2633
### Bug Fixes
2734

0 commit comments

Comments
 (0)