Skip to content

Commit ce51fc1

Browse files
committed
make: use GO_VERSION=1 for release builds
We have forgotten to bump GO_VERSION in our Dockerfile several times when doing releases from old release branches, leading to use using EOL'd Go versions for releases. We should just always use the latest version when building our release artefacts. Signed-off-by: Aleksa Sarai <[email protected]> (cherry picked from commit 174ccef) Signed-off-by: Aleksa Sarai <[email protected]>
1 parent b478208 commit ce51fc1

File tree

1 file changed

+4
-0
lines changed

1 file changed

+4
-0
lines changed

Makefile

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,9 @@
11
SHELL = /bin/bash
22

33
CONTAINER_ENGINE := docker
4+
CONTAINER_ENGINE_BUILD_FLAGS ?=
5+
CONTAINER_ENGINE_RUN_FLAGS ?=
6+
47
GO ?= go
58

69
PREFIX ?= /usr/local
@@ -112,6 +115,7 @@ releaseall: RELEASE_ARGS := "-a 386 -a amd64 -a arm64 -a armel -a armhf -a ppc64
112115
releaseall: release
113116

114117
.PHONY: release
118+
release: CONTAINER_ENGINE_BUILD_FLAGS := --build-arg GO_VERSION=1
115119
release: runcimage
116120
$(CONTAINER_ENGINE) run $(CONTAINER_ENGINE_RUN_FLAGS) \
117121
--rm -v $(CURDIR):/go/src/$(PROJECT) \

0 commit comments

Comments
 (0)