Fix issues with templates in KFTO SDK test

Author: jiripetrlik

tests/common/notebook.go

@@ -19,6 +19,7 @@ package common
 import (
 	"bytes"
 	"embed"
+	"strings"
 
 	gomega "github.com/onsi/gomega"
 	. "github.com/project-codeflare/codeflare-common/support"
@@ -53,7 +54,7 @@ type NotebookProps struct {
 	KubernetesUserBearerToken string
 	Namespace                 string
 	OpenDataHubNamespace      string
-	Command                   []string
+	Command                   string
 	NotebookImage             string
 	NotebookConfigMapName     string
 	NotebookConfigMapFileName string
@@ -76,6 +77,7 @@ func CreateNotebook(test Test, namespace *corev1.Namespace, notebookUserToken st
 	s3SecretAccessKey, _ := GetStorageBucketSecretKey()
 	s3Endpoint, _ := GetStorageBucketDefaultEndpoint()
 	s3DefaultRegion, _ := GetStorageBucketDefaultRegion()
+	strCommand := "[\"" + strings.Join(command, "\",\"") + "\"]"
 
 	if !s3BucketNameExists {
 		s3BucketName = "''"
@@ -92,7 +94,7 @@ func CreateNotebook(test Test, namespace *corev1.Namespace, notebookUserToken st
 		KubernetesUserBearerToken: notebookUserToken,
 		Namespace:                 namespace.Name,
 		OpenDataHubNamespace:      GetOpenDataHubNamespace(test),
-		Command:                   command,
+		Command:                   strCommand,
 		NotebookImage:             GetNotebookImage(test),
 		NotebookConfigMapName:     jupyterNotebookConfigMapName,
 		NotebookConfigMapFileName: jupyterNotebookConfigMapFileName,
@@ -109,6 +111,7 @@ func CreateNotebook(test Test, namespace *corev1.Namespace, notebookUserToken st
 	notebookTemplate, err := files.ReadFile("resources/custom-nb-small.yaml")
 	test.Expect(err).NotTo(gomega.HaveOccurred())
 
+	notebookTemplate = ParseTemplate(test, notebookTemplate, notebookProps)
 	parsedNotebookTemplate := ParseTemplate(test, notebookTemplate, notebookProps)
 
 	// Create Notebook CR

tests/kfto/kfto_mnist_sdk_test.go

@@ -60,12 +60,12 @@ func TestMnistSDK(t *testing.T) {
 	})
 
 	notebookCommand := []string{
-		"bin/sh",
+		"/bin/sh",
 		"-c",
 		"pip install papermill && papermill /opt/app-root/notebooks/{{.NotebookConfigMapFileName}}" +
 			" /opt/app-root/src/mcad-out.ipynb -p namespace {{.Namespace}} -p openshift_api_url {{.OpenShiftApiUrl}}" +
 			" -p kubernetes_user_bearer_token {{.KubernetesUserBearerToken}}" +
-			" -p num_gpus {{ .NumGpus }} --log-output && sleep infinity",
+			" -p num_gpus {{.NumGpus}} --log-output && sleep infinity",
 	}
 	// Create Notebook CR
 	CreateNotebook(test, namespace, userToken, notebookCommand, config.Name, jupyterNotebookConfigMapFileName, 0)

tests/kfto/resources/mnist_kfto.ipynb

@@ -55,7 +55,7 @@
     "   name=\"pytorch-ddp\",\n",
     "   namespace=namespace,\n",
     "   train_func=train_func,\n",
-    "   num_workers=2,\n",
+    "   num_workers=1,\n",
     "   resources_per_worker={\"gpu\": num_gpus},\n",
     "   base_image=\"quay.io/kpostlet/torch-train:with-minivision\",\n",
     "   # packages_to_install=[\"torchvision==0.19.0\", \"--target=/tmp/lib\"],\n",