Skip to content

Commit 5a49ad7

Browse files
sutaakaropenshift-merge-bot[bot]
authored andcommitted
Remove default fms-hf-tuning image
1 parent f39ebd6 commit 5a49ad7

File tree

3 files changed

+10
-4
lines changed

3 files changed

+10
-4
lines changed

tests/kfto/core/environment.go

Lines changed: 8 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -18,6 +18,8 @@ package core
1818

1919
import (
2020
"os"
21+
22+
. "github.com/project-codeflare/codeflare-common/support"
2123
)
2224

2325
const (
@@ -27,8 +29,12 @@ const (
2729
bloomModelImageEnvVar = "BLOOM_MODEL_IMAGE"
2830
)
2931

30-
func GetFmsHfTuningImage() string {
31-
return lookupEnvOrDefault(fmsHfTuningImageEnvVar, "quay.io/modh/fms-hf-tuning:bd8bf628cd739c7a201a976bc3c1096785353f1a")
32+
func GetFmsHfTuningImage(t Test) string {
33+
image, ok := os.LookupEnv(fmsHfTuningImageEnvVar)
34+
if !ok {
35+
t.T().Fatalf("Expected environment variable %s not found, please use this environment variable to specify fms-hf-tuning image to be tested.", fmsHfTuningImageEnvVar)
36+
}
37+
return image
3238
}
3339

3440
func GetBloomModelImage() string {

tests/kfto/core/kfto_kueue_sft_test.go

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -200,7 +200,7 @@ func createPyTorchJob(test Test, namespace, localQueueName string, config corev1
200200
Containers: []corev1.Container{
201201
{
202202
Name: "pytorch",
203-
Image: GetFmsHfTuningImage(),
203+
Image: GetFmsHfTuningImage(test),
204204
ImagePullPolicy: corev1.PullIfNotPresent,
205205
Env: []corev1.EnvVar{
206206
{

tests/kfto/upgrade/kfto_kueue_sft_upgrade_test.go

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -164,7 +164,7 @@ func createPyTorchJob(test Test, namespace, localQueueName string, config corev1
164164
Containers: []corev1.Container{
165165
{
166166
Name: "pytorch",
167-
Image: kftocore.GetFmsHfTuningImage(),
167+
Image: kftocore.GetFmsHfTuningImage(test),
168168
ImagePullPolicy: corev1.PullIfNotPresent,
169169
Env: []corev1.EnvVar{
170170
{

0 commit comments

Comments
 (0)