Skip to content

Commit a6578fc

Browse files
sutaakaropenshift-merge-robot
authored andcommitted
Defer retrieving GetRayJobId in test
1 parent 4816d9d commit a6578fc

File tree

3 files changed

+4
-4
lines changed

3 files changed

+4
-4
lines changed

tests/go.mod

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -3,7 +3,7 @@ module github.com/opendatahub-io/distributed-workloads/tests/new-tests
33
require (
44
github.com/onsi/gomega v1.27.8
55
github.com/openshift/api v0.0.0-20230718161610-2a3e8b481cec
6-
github.com/project-codeflare/codeflare-operator v0.1.1-0.20230817124305-be0dd48b43b4
6+
github.com/project-codeflare/codeflare-operator v0.1.1-0.20230823091637-6f7d6b1194dd
77
github.com/ray-project/kuberay/ray-operator v0.0.0-20230807232553-238cb4e945b6
88
k8s.io/api v0.27.2
99
k8s.io/apimachinery v0.27.2

tests/go.sum

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -87,8 +87,8 @@ github.com/openshift/client-go v0.0.0-20230718165156-6014fb98e86a h1:ZKewwwEIURD
8787
github.com/openshift/client-go v0.0.0-20230718165156-6014fb98e86a/go.mod h1:EjhPQjEm8HM3GThz5ywNGLEec1P1IjTn08kwzdvupvA=
8888
github.com/pmezard/go-difflib v1.0.0 h1:4DBwDE0NGyQoBHbLQYPwSUPoCMWR5BEzIk/f1lZbAQM=
8989
github.com/pmezard/go-difflib v1.0.0/go.mod h1:iKH77koFhYxTK1pcRnkKkqfTogsbg7gZNVY4sRDYZ/4=
90-
github.com/project-codeflare/codeflare-operator v0.1.1-0.20230817124305-be0dd48b43b4 h1:zEkjcrKhY3XC3TNGWFg6QlFZuC2BWfRufAvv+xrVFb8=
91-
github.com/project-codeflare/codeflare-operator v0.1.1-0.20230817124305-be0dd48b43b4/go.mod h1:BtKefU7oi9bb9M2flQXERqjX3KNTVe9uWkD0C2wdHjM=
90+
github.com/project-codeflare/codeflare-operator v0.1.1-0.20230823091637-6f7d6b1194dd h1:c1CrFGX9pRPm4vTx5U+A5ptY51gKEM3hhcrPBdEN7bk=
91+
github.com/project-codeflare/codeflare-operator v0.1.1-0.20230823091637-6f7d6b1194dd/go.mod h1:BtKefU7oi9bb9M2flQXERqjX3KNTVe9uWkD0C2wdHjM=
9292
github.com/project-codeflare/multi-cluster-app-dispatcher v1.33.0 h1:6a+MnxcFSlheC7RIPGg3s/QCt5+7dD8mJKwdpST7i70=
9393
github.com/project-codeflare/multi-cluster-app-dispatcher v1.33.0/go.mod h1:0J0BDSaIN5lvlmgw+32FcMqe8SflXHtHByUbHmPl4w8=
9494
github.com/prometheus/client_model v0.0.0-20190812154241-14fe0d1b01d4/go.mod h1:xMI15A0UPsDsEKsMN9yxemIoYk6Tm2C1GtYGdfGttqA=

tests/integration/ray_test.go

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -112,7 +112,7 @@ func TestRayCluster(t *testing.T) {
112112
dashboardHostname := dashboard.Status.Ingress[0].Host
113113

114114
rayClient := support.NewRayClusterClient(url.URL{Scheme: "http", Host: dashboardHostname})
115-
defer support.WriteRayJobAPILogs(test, rayClient, support.GetRayJobId(test, rayJob.Namespace, rayJob.Name))
115+
defer support.WriteRayJobLogs(test, rayClient, rayJob.Namespace, rayJob.Name)
116116

117117
test.T().Logf("Waiting for RayJob %s/%s to complete", rayJob.Namespace, rayJob.Name)
118118
test.Eventually(support.RayJob(test, rayJob.Namespace, rayJob.Name), support.TestTimeoutLong).

0 commit comments

Comments
 (0)