Skip to content

Commit 2a66046

Browse files
authored
Change tests that expect smirnoff99Frosst ffs to not expect them (#2109)
* change tests that expect s99F ffs to not expect them * remove s99f from test files * update releasenotes
1 parent 76ffd16 commit 2a66046

File tree

7 files changed

+3
-9
lines changed

7 files changed

+3
-9
lines changed

devtools/conda-envs/openeye-examples.yaml

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -14,7 +14,6 @@ dependencies:
1414
- python-constraint
1515
- openmm >=7.6
1616
- openff-forcefields >=2023.11
17-
- smirnoff99Frosst
1817
- openff-amber-ff-ports >=0.0.3
1918
- openff-units
2019
- openff-utilities >=0.1.5

devtools/conda-envs/openeye.yaml

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -14,7 +14,6 @@ dependencies:
1414
- python-constraint
1515
- openmm >=7.6
1616
- openff-forcefields >=2023.05.1
17-
- smirnoff99Frosst
1817
- openff-units
1918
- openff-amber-ff-ports
2019
- openff-utilities >=0.1.5

devtools/conda-envs/rdkit-examples.yaml

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -13,7 +13,6 @@ dependencies:
1313
- python-constraint
1414
- openmm >=7.6
1515
- openff-forcefields >=2023.11
16-
- smirnoff99Frosst
1716
- openff-amber-ff-ports >=0.0.3
1817
- openff-units
1918
- openff-utilities >=0.1.5

devtools/conda-envs/rdkit.yaml

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -13,7 +13,6 @@ dependencies:
1313
- python-constraint
1414
- openmm >=7.6
1515
- openff-forcefields >=2023.05.1
16-
- smirnoff99Frosst
1716
- openff-units
1817
- openff-amber-ff-ports
1918
- openff-utilities >=0.1.5

devtools/conda-envs/test_env.yaml

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -14,7 +14,6 @@ dependencies:
1414
- python-constraint
1515
- openmm >=7.6
1616
- openff-forcefields >=2023.05.1
17-
- smirnoff99Frosst
1817
- openff-units
1918
- openff-amber-ff-ports
2019
- openff-utilities >=0.1.5

docs/releasehistory.md

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -14,6 +14,7 @@ Releases follow the `major.minor.micro` scheme recommended by [PEP440](https://w
1414

1515
### Bugfixes
1616
- [PR #2107](https://github.com/openforcefield/openff-toolkit/pull/2107): Fixes [Issue #2093](https://github.com/openforcefield/openff-toolkit/issues/2093), where in rare cases `Topology.from_pdb` would mangle the order/coordinates of loaded atoms, by making it raise a `PDBMoleculeHasNoncontiguousAtomIndicesError` instead.
17+
- [PR #2109](https://github.com/openforcefield/openff-toolkit/pull/2109): Fixes [Issue #2108](https://github.com/openforcefield/openff-toolkit/issues/2108) by updating tests to reflect that smirnoff99Frosst is no longer installed as a dependency of the OpenFF Toolkit.
1718

1819

1920
### New features

openff/toolkit/_tests/test_forcefield.py

Lines changed: 2 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -782,8 +782,6 @@ def test_get_available_force_fields(self):
782782

783783
# Incomplete list of some expected force fields
784784
expected_force_fields = [
785-
"smirnoff99Frosst-1.0.0.offxml",
786-
"smirnoff99Frosst-1.1.0.offxml",
787785
"openff-1.0.0.offxml",
788786
"openff_unconstrained-1.0.0.offxml",
789787
"openff-1.3.0.offxml",
@@ -809,8 +807,8 @@ def test_get_available_force_fields_loadable(self, full_path, force_field_file):
809807

810808
def test_force_field_case(self):
811809
"""Ensure forcefield paths are loaded in a case-insensitive manner"""
812-
default_case = ForceField("smirnoff99Frosst-1.1.0.offxml")
813-
lower_case = ForceField("smirnoff99frosst-1.1.0.offxml")
810+
default_case = ForceField("openff-2.0.0.offxml")
811+
lower_case = ForceField("oPeNFF-2.0.0.offxml")
814812

815813
assert hash(default_case) == hash(lower_case)
816814

0 commit comments

Comments
 (0)