Skip to content

Commit 1670056

Browse files
committed
fix: get task run result
1 parent cc02baf commit 1670056

File tree

2 files changed

+14
-17
lines changed

2 files changed

+14
-17
lines changed

services/tasks/db/db.go

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -58,7 +58,7 @@ func (db Database) GetTask(id string) (*models.Task, error) {
5858
// GetTaskRunResult retrieves a task result by Task ID
5959
func (db Database) GetTaskRunResult(id string) ([]models.TaskRun, error) {
6060
var task []models.TaskRun
61-
tx := db.Orm.Where("task_id = ?", id).
61+
tx := db.Orm.Where("id = ?", id).
6262
Order("created_at desc").
6363
Find(&task)
6464
if tx.Error != nil {

services/tasks/http.go

Lines changed: 13 additions & 16 deletions
Original file line numberDiff line numberDiff line change
@@ -85,7 +85,6 @@ func (r *httpRoutes) ListTasks(ctx echo.Context) error {
8585

8686
}
8787

88-
8988
totalCount := len(items)
9089
if perPage != 0 {
9190
if cursor == 0 {
@@ -102,12 +101,11 @@ func (r *httpRoutes) ListTasks(ctx echo.Context) error {
102101
ResultType: task.ResultType,
103102
Description: task.Description,
104103
ImageUrl: task.ImageUrl,
105-
Interval: task.Interval,
106-
Timeout: task.Timeout,
104+
Interval: task.Interval,
105+
Timeout: task.Timeout,
107106
})
108107
}
109108

110-
111109
return ctx.JSON(http.StatusOK, api.TaskListResponse{
112110
TotalCount: totalCount,
113111
Items: taskResponses,
@@ -137,11 +135,10 @@ func (r *httpRoutes) GetTask(ctx echo.Context) error {
137135
ResultType: task.ResultType,
138136
Description: task.Description,
139137
ImageUrl: task.ImageUrl,
140-
Interval: task.Interval,
141-
Timeout: task.Timeout,
138+
Interval: task.Interval,
139+
Timeout: task.Timeout,
142140
}
143141

144-
145142
return ctx.JSON(http.StatusOK, taskResponse)
146143
}
147144

@@ -241,20 +238,20 @@ func (r *httpRoutes) GetTaskRunResult(ctx echo.Context) error {
241238
r.logger.Error("failed to unmarshal params", zap.Error(err))
242239
return ctx.JSON(http.StatusInternalServerError, "failed to unmarshal params")
243240
}
244-
// var result map[string]interface{}
245-
// err = json.Unmarshal(task.Result.Bytes, &result)
246-
// if err != nil {
247-
// r.logger.Error("failed to unmarshal result", zap.Error(err))
248-
// return ctx.JSON(http.StatusInternalServerError, "failed to unmarshal result")
249-
// }
241+
var result map[string]interface{}
242+
err = json.Unmarshal(task.Result.Bytes, &result)
243+
if err != nil {
244+
r.logger.Error("failed to unmarshal result", zap.Error(err))
245+
return ctx.JSON(http.StatusInternalServerError, "failed to unmarshal result")
246+
}
250247
taskRunResponses = append(taskRunResponses, api.TaskRun{
251248
ID: task.ID,
252249
CreatedAt: task.CreatedAt,
253250
UpdatedAt: task.UpdatedAt,
254251
TaskID: task.TaskID,
255252
Status: string(task.Status),
256-
// Result: result,
257-
Params: params,
253+
Result: result,
254+
Params: params,
258255
FailureMessage: task.FailureMessage,
259256
})
260257
}
@@ -329,7 +326,7 @@ func (r *httpRoutes) ListTaskRunResult(ctx echo.Context) error {
329326
TaskID: task.TaskID,
330327
Status: string(task.Status),
331328
Result: result,
332-
Params: params,
329+
Params: params,
333330
FailureMessage: task.FailureMessage,
334331
})
335332
}

0 commit comments

Comments
 (0)