fix: remove dry-run and fix invalid parameters in cleanup workflow

Remove unsupported dry-run functionality and fix invalid parameter names
to resolve workflow warnings. Changes include:

- Remove dry_run input parameter and all related conditional logic
- Fix oldest-to-delete parameter to use correct num-old-versions-to-delete
- Remove unsupported dry-run parameter from action calls
- Simplify workflow to only support actual cleanup operations

This resolves the "Unexpected input" warnings and makes the workflow
use only valid parameters supported by actions/delete-package-versions@v5.

Signed-off-by: Adrian Reber <[email protected]>

Author: adrianreber

.github/workflows/cleanup-packages.yml

@@ -5,12 +5,6 @@ on:
     # Run every Sunday at 02:00 UTC
     - cron: '0 2 * * 0'
   workflow_dispatch:
-    inputs:
-      dry_run:
-        description: 'Dry run (preview what would be deleted)'
-        required: false
-        default: 'false'
-        type: boolean
 
 env:
   REGISTRY: ghcr.io
@@ -27,7 +21,6 @@ jobs:
           echo "Repository: ${{ github.repository }}"
           echo "Repository owner: ${{ github.repository_owner }}"
           echo "Repository name: ${{ github.event.repository.name }}"
-          echo "Dry run: ${{ github.event.inputs.dry_run }}"
 
       - name: Delete untagged main container images
         id: cleanup-main
@@ -39,7 +32,6 @@ jobs:
           min-versions-to-keep: 5
           delete-only-untagged-versions: true
           token: ${{ secrets.GITHUB_TOKEN }}
-          dry-run: ${{ github.event.inputs.dry_run == 'true' }}
 
       - name: Delete untagged ohpc-lint images
         id: cleanup-lint
@@ -51,7 +43,6 @@ jobs:
           min-versions-to-keep: 3
           delete-only-untagged-versions: true
           token: ${{ secrets.GITHUB_TOKEN }}
-          dry-run: ${{ github.event.inputs.dry_run == 'true' }}
 
       - name: Delete old package versions (keep recent tagged)
         id: cleanup-old
@@ -61,9 +52,8 @@ jobs:
           package-name: ${{ github.event.repository.name }}
           package-type: container
           min-versions-to-keep: 10
-          oldest-to-delete: 30 # Delete versions older than 30 days
+          num-old-versions-to-delete: 30
           token: ${{ secrets.GITHUB_TOKEN }}
-          dry-run: ${{ github.event.inputs.dry_run == 'true' }}
 
       - name: Report cleanup results
         run: |