8364560: The default value of --linux-menu-group option is invalid

[alexeysemenyukoracle]

• Set the default value of the "Categories" key in .desktop files to "Utility".
  • The value of the "Categories" key is an ID, not a localizable string. This is why the "param.menu-group.default" localization key was removed.
• Add a test for the "--linux-menu-group" option.

---

Progress

• Change must be properly reviewed (1 review required, with at least 1 Reviewer)
• Change must not contain extraneous whitespace
• Commit message must refer to an issue

Issues

• JDK-8364560: The default value of --linux-menu-group option is invalid (Bug - P4)
• JDK-8356574: Test --linux-menu-group option (Enhancement - P4)

Reviewers

• Alexander Matveev (@sashamatveev - Reviewer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/28298/head:pull/28298
$ git checkout pull/28298

Update a local copy of the PR:
$ git checkout pull/28298
$ git pull https://git.openjdk.org/jdk.git pull/28298/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 28298

View PR using the GUI difftool:
$ git pr show -t 28298

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/28298.diff

Using Webrev

Link to Webrev Comment

[bridgekeeper]

👋 Welcome back asemenyuk! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@alexeysemenyukoracle This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8364560: The default value of --linux-menu-group option is invalid
8356574: Test --linux-menu-group option

Reviewed-by: almatvee

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 133 new commits pushed to the master branch:

• 6322aab: 8371821: Duplicate export of jdk.internal.util to java.net.http
• db3a838: 8371436: (fs) java/nio/file/FileStore/Basic.java fails on macOS platform due to assertTrue(!store.equals(prev));
• d09a8cb: 8371746: Some imports in Integer.java and Long.java became unused after JDK-8370503
• ... and 130 more: https://git.openjdk.org/jdk/compare/c8f5fd6ff3808804eda03c9754698a00dd06449c...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

[openjdk]

@alexeysemenyukoracle The following label will be automatically applied to this pull request:

• core-libs

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

[alexeysemenyukoracle]

/issue add JDK-8356574

[openjdk]

@alexeysemenyukoracle
Adding additional issue to issue list: 8356574: Test --linux-menu-group option.

[alexeysemenyukoracle]

@sashamatveev PTAL

[mlbridge]

Webrevs

• 00: Full (a6c425f6)

[sashamatveev]

Looks good.

[alexeysemenyukoracle]

/integrate

[openjdk]

Going to push as commit 0d8b518.
Since your change was applied there have been 134 commits pushed to the master branch:

• 155d7df: 8371749: New test serviceability/jvmti/events/VMDeath/AllocatingInVMDeath/TestAllocatingInVMDeath.java fails with -Xcheck:jni
• 6322aab: 8371821: Duplicate export of jdk.internal.util to java.net.http
• db3a838: 8371436: (fs) java/nio/file/FileStore/Basic.java fails on macOS platform due to assertTrue(!store.equals(prev));
• ... and 131 more: https://git.openjdk.org/jdk/compare/c8f5fd6ff3808804eda03c9754698a00dd06449c...master

Your commit was automatically rebased without conflicts.

[openjdk]

@alexeysemenyukoracle Pushed as commit 0d8b518.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.