Allow users with workspace write permission to edit notebook (#258)

FriedhelmWS · web-flow · commit 66c65323ba4e · 2025-12-10T18:50:17.000+08:00
Signed-off-by: Owen Wang &lt;owenwyk@amazon.com&gt;
diff --git a/common/state/notebook_state.ts b/common/state/notebook_state.ts
@@ -25,7 +25,7 @@ export interface NotebookStateValue {
   runningMemory?: AgenticMemeory;
   historyMemory?: AgenticMemeory;
   investigationError?: string;
-  isNotebookOwner: boolean;
+  isNotebookReadonly: boolean;
 }
 
 export class NotebookState extends ObservableState<NotebookStateValue> {
diff --git a/public/components/notebooks/components/agentic_notebook.tsx b/public/components/notebooks/components/agentic_notebook.tsx
@@ -59,9 +59,16 @@ interface AgenticNotebookProps extends NotebookComponentProps {
 
 function NotebookComponent({ showPageHeader }: NotebookComponentProps) {
   const {
-    services: { notifications, findingService, chrome, chat, uiSettings, contextProvider },
+    services: {
+      notifications,
+      findingService,
+      chrome,
+      chat,
+      uiSettings,
+      contextProvider,
+      workspaces,
+    },
   } = useOpenSearchDashboards<NoteBookServices>();
-
   const [isModalVisible, setIsModalVisible] = useState(false);
   const [isReinvestigateModalVisible, setIsReinvestigateModalVisible] = useState(false);
   const [modalLayout, setModalLayout] = useState<React.ReactNode>(<EuiOverlayMask />);
@@ -81,7 +88,7 @@ function NotebookComponent({ showPageHeader }: NotebookComponentProps) {
     id: openedNoteId,
     paragraphs: paragraphsStates,
     isLoading,
-    isNotebookOwner,
+    isNotebookReadonly,
   } = useObservable(notebookContext.state.getValue$(), notebookContext.state.value);
   const paraDivRefs = useRef<Array<HTMLDivElement | null>>([]);
 
@@ -107,6 +114,13 @@ function NotebookComponent({ showPageHeader }: NotebookComponentProps) {
     closeModal();
   };
 
+  useEffect(() => {
+    const subscription = workspaces.currentWorkspace$.subscribe((currentWorkspace) => {
+      notebookContext.state.updateValue({ isNotebookReadonly: currentWorkspace?.readonly });
+    });
+    return () => subscription.unsubscribe();
+  }, [workspaces.currentWorkspace$, notebookContext.state]);
+
   // Initialize finding integration for automatic UI updates when findings are added
   useNotebookFindingIntegration({
     findingService,
@@ -159,7 +173,6 @@ function NotebookComponent({ showPageHeader }: NotebookComponentProps) {
           hypotheses: res.hypotheses,
           runningMemory: res.runningMemory,
           historyMemory: res.historyMemory,
-          isNotebookOwner: res.isNotebookOwner,
         });
 
         // Check if there's an ongoing investigation to continue BEFORE calling start
@@ -204,7 +217,7 @@ function NotebookComponent({ showPageHeader }: NotebookComponentProps) {
     // TODO: remove the optional chain after each method
     (chrome as any).setIsNavDrawerLocked?.(false);
     const rafId = window.requestAnimationFrame(() => {
-      chat?.openWindow?.();
+      (chat as any)?.openWindow?.();
     });
     return () => {
       window.cancelAnimationFrame(rafId);
@@ -346,7 +359,7 @@ function NotebookComponent({ showPageHeader }: NotebookComponentProps) {
               })
             : null}
 
-          {!isLoading && !isInvestigating && isNotebookOwner && (
+          {!isLoading && !isInvestigating && !isNotebookReadonly && (
             <>
               <EuiSpacer size="s" />
               <EuiFlexGroup alignItems="center" gutterSize="none">
diff --git a/public/components/notebooks/components/hypothesis/hypotheses_panel.tsx b/public/components/notebooks/components/hypothesis/hypotheses_panel.tsx
@@ -56,7 +56,7 @@ export const HypothesesPanel: React.FC<HypothesesPanelProps> = ({
     runningMemory,
     historyMemory,
     investigationError,
-    isNotebookOwner,
+    isNotebookReadonly,
   } = useObservable(notebookContext.state.getValue$(), notebookContext.state.value);
   const history = useHistory();
   const [showSteps, setShowSteps] = useState(false);
@@ -66,7 +66,7 @@ export const HypothesesPanel: React.FC<HypothesesPanelProps> = ({
   }, [isInvestigating, runningMemory, historyMemory]);
 
   const PERAgentServices = useMemo(() => {
-    if (!activeMemory?.executorMemoryId || !activeMemory?.memoryContainerId || !isNotebookOwner) {
+    if (!activeMemory?.executorMemoryId || !activeMemory?.memoryContainerId || isNotebookReadonly) {
       return null;
     }
 
@@ -80,7 +80,7 @@ export const HypothesesPanel: React.FC<HypothesesPanelProps> = ({
         if (!isInvestigating && activeMemory) {
           return false;
         }
-        return !messageService.getMessageValue()?.hits?.hits?.[0]?._source?.structured_data
+        return !(messageService.getMessageValue() as any)?.hits?.hits?.[0]?._source?.structured_data
           ?.response;
       },
       activeMemory.memoryContainerId
@@ -90,7 +90,7 @@ export const HypothesesPanel: React.FC<HypothesesPanelProps> = ({
       message: messageService,
       executorMemory: executorMemoryService,
     };
-  }, [http, activeMemory, isInvestigating, isNotebookOwner]);
+  }, [http, activeMemory, isInvestigating, isNotebookReadonly]);
 
   const executorMessages$ = useMemo(
     () => PERAgentServices?.executorMemory.getMessages$() ?? new BehaviorSubject<any[]>([]),
@@ -173,7 +173,7 @@ export const HypothesesPanel: React.FC<HypothesesPanelProps> = ({
     return null;
   }
 
-  const investigationSteps = PERAgentServices && isNotebookOwner && (
+  const investigationSteps = PERAgentServices && !isNotebookReadonly && (
     <EuiAccordion
       id="investigation-steps"
       buttonContent="Investigation Steps"
@@ -257,7 +257,7 @@ export const HypothesesPanel: React.FC<HypothesesPanelProps> = ({
               AI Agent continuously evaluates and ranks hypotheses based on evidence
             </EuiText>
           </EuiFlexGroup>
-          {hypotheses?.length && !isInvestigating ? (
+          {hypotheses?.length && !isInvestigating && !isNotebookReadonly ? (
             <HypothesesFeedback
               appName={appName}
               usageCollection={usageCollection}
@@ -276,7 +276,7 @@ export const HypothesesPanel: React.FC<HypothesesPanelProps> = ({
           }}
           dataSourceId={context.value.dataSourceId}
           currentExecutorMemoryId={activeMemory?.executorMemoryId}
-          memoryContainerId={activeMemory?.memoryContainerId}
+          memoryContainerId={activeMemory?.memoryContainerId as string}
         />
       )}
     </>
diff --git a/public/components/notebooks/components/paragraph_components/paragraph.tsx b/public/components/notebooks/components/paragraph_components/paragraph.tsx
@@ -42,7 +42,7 @@ export const Paragraph = (props: ParagraphProps) => {
   const isFindingParagraph =
     notebookType !== NotebookType.CLASSIC && paragraph.value.input.inputType === 'MARKDOWN';
   let isActionVisible = isClassicNotebook;
-  if (!isClassicNotebook && isFindingParagraph && context.state.value.isNotebookOwner) {
+  if (!isClassicNotebook && isFindingParagraph && !context.state.value.isNotebookReadonly) {
     isActionVisible = true;
   }
 
diff --git a/public/components/notebooks/components/summary_card.tsx b/public/components/notebooks/components/summary_card.tsx
@@ -46,7 +46,7 @@ export const SummaryCard: React.FC<SummaryCardProps> = ({
     });
   };
 
-  const { isNotebookOwner } = useObservable(
+  const { isNotebookReadonly } = useObservable(
     notebookContext.state.getValue$(),
     notebookContext.state.value
   );
@@ -93,7 +93,7 @@ export const SummaryCard: React.FC<SummaryCardProps> = ({
         <EuiTitle>
           <h2 style={{ paddingLeft: '20px' }}>Issue summary and impact</h2>
         </EuiTitle>
-        {isNotebookOwner ? (
+        {!isNotebookReadonly ? (
           <EuiButton
             style={{ marginRight: '20px' }}
             onClick={() => openReinvestigateModal()}
diff --git a/public/hooks/use_investigation.ts b/public/hooks/use_investigation.ts
@@ -319,8 +319,10 @@ ${finding.evidence}
       context.state.updateValue({ investigationError: undefined });
 
       try {
-        if (!context.state.value.isNotebookOwner) {
-          throw new Error('Only owner of this notebook can start the investigation');
+        if (context.state.value.isNotebookReadonly) {
+          throw new Error(
+            'Only user with write permission of this notebook can start the investigation'
+          );
         }
 
         if (context.state.value.context.value.initialGoal !== question) {
diff --git a/public/hooks/use_notebook.tsx b/public/hooks/use_notebook.tsx
@@ -88,53 +88,51 @@ export const useNotebook = () => {
       isLoading: true,
     });
 
-    const promise = http
-      .get<NotebookBackendType & { isNotebookOwner: boolean }>(route)
-      .then(async (res) => {
-        let contextPayload = {
-          ...res.context,
-        };
-
-        // try to convert relative time in ppl query to absolute time as
-        if (res.context?.variables?.pplQuery) {
-          const pplWithAbsoluteTime = parsePPLQuery(
-            res.context.variables.pplQuery,
-            res.context.currentTime
-          ).pplWithAbsoluteTime;
-          if (pplWithAbsoluteTime !== res.context.variables.pplQuery) {
-            contextPayload = {
-              ...contextPayload,
-              variables: {
-                ...contextPayload.variables,
-                pplQuery: pplWithAbsoluteTime,
-              },
-            };
-          }
-        }
-
-        if (
-          !res.context?.indexInsight &&
-          res.context?.index &&
-          res.context?.timeField &&
-          res.context?.timeRange
-        ) {
-          let indexInsight;
-          try {
-            indexInsight = await fetchIndexInsights(res.context.index, res.context?.dataSourceId);
-          } catch (error) {
-            console.error('Failed to load index insight:', error);
-          }
+    const promise = http.get<NotebookBackendType>(route).then(async (res) => {
+      let contextPayload = {
+        ...res.context,
+      };
+
+      // try to convert relative time in ppl query to absolute time as
+      if (res.context?.variables?.pplQuery) {
+        const pplWithAbsoluteTime = parsePPLQuery(
+          res.context.variables.pplQuery,
+          res.context.currentTime
+        ).pplWithAbsoluteTime;
+        if (pplWithAbsoluteTime !== res.context.variables.pplQuery) {
           contextPayload = {
             ...contextPayload,
-            indexInsight,
+            variables: {
+              ...contextPayload.variables,
+              pplQuery: pplWithAbsoluteTime,
+            },
           };
         }
-        return {
-          ...res,
-          vizPrefix: res.vizPrefix || '',
-          context: contextPayload,
+      }
+
+      if (
+        !res.context?.indexInsight &&
+        res.context?.index &&
+        res.context?.timeField &&
+        res.context?.timeRange
+      ) {
+        let indexInsight;
+        try {
+          indexInsight = await fetchIndexInsights(res.context.index, res.context?.dataSourceId);
+        } catch (error) {
+          console.error('Failed to load index insight:', error);
+        }
+        contextPayload = {
+          ...contextPayload,
+          indexInsight,
         };
-      });
+      }
+      return {
+        ...res,
+        vizPrefix: res.vizPrefix || '',
+        context: contextPayload,
+      };
+    });
 
     promise.finally(() => {
       context.state.updateValue({
diff --git a/public/plugin.tsx b/public/plugin.tsx
@@ -107,6 +107,7 @@ export class InvestigationPlugin
         findingService,
         usageCollection: depsStart.usageCollection,
         overlay: depsStart.overlay,
+        workspaces: coreStart.workspaces,
       };
       return services;
     };
diff --git a/server/adaptors/notebooks/saved_objects_notebooks_router.tsx b/server/adaptors/notebooks/saved_objects_notebooks_router.tsx
@@ -69,6 +69,7 @@ export function cloneNotebook(fetchedNotebook: NotebookBackendType, name: string
     backend: 'kibana_1.0',
     paragraphs: fetchedNotebook.paragraphs,
     path: name,
+    owner: fetchedNotebook.owner,
   };
 
   return {
diff --git a/server/routes/notebooks/notebook_router.ts b/server/routes/notebooks/notebook_router.ts
@@ -219,7 +219,7 @@ export function registerNoteRoute(router: IRouter, auth: HttpAuth) {
           request.body.notebookId,
           opensearchNotebooksClient
         );
-        noteBookInfo.attributes.savedNotebook = {
+        (noteBookInfo.attributes as any).savedNotebook = {
           ...noteBookInfo.attributes.savedNotebook,
           ...noteObject,
         };
@@ -265,14 +265,9 @@ export function registerNoteRoute(router: IRouter, auth: HttpAuth) {
           NOTEBOOK_SAVED_OBJECT,
           request.params.noteId
         );
-        const savedNotebook = notebookinfo.attributes.savedNotebook as NotebookBackendType;
+        const savedNotebook = (notebookinfo as any).attributes.savedNotebook as NotebookBackendType;
         return response.ok({
-          body: {
-            ...savedNotebook,
-            isNotebookOwner: savedNotebook.owner
-              ? savedNotebook.owner === getUserName(request)
-              : true,
-          },
+          body: savedNotebook,
         });
       } catch (error) {
         return response.custom({
@@ -306,7 +301,7 @@ export function registerNoteRoute(router: IRouter, auth: HttpAuth) {
           request.body.noteId
         );
         const createCloneNotebook = cloneNotebook(
-          getNotebook.attributes.savedNotebook,
+          (getNotebook as any).attributes.savedNotebook,
           request.body.name
         );
         const createdNotebook = await opensearchNotebooksClient.create(

Original file line number	Diff line number	Diff line change
`@@ -25,7 +25,7 @@ export interface NotebookStateValue {`
`25`	`25`	`runningMemory?: AgenticMemeory;`
`26`	`26`	`historyMemory?: AgenticMemeory;`
`27`	`27`	`investigationError?: string;`
`28`		`- isNotebookOwner: boolean;`
	`28`	`+ isNotebookReadonly: boolean;`
`29`	`29`	`}`
`30`	`30`
`31`	`31`	`export class NotebookState extends ObservableState<NotebookStateValue> {`
Original file line number	Diff line number	Diff line change
`@@ -42,7 +42,7 @@ export const Paragraph = (props: ParagraphProps) => {`
`42`	`42`	`const isFindingParagraph =`
`43`	`43`	`notebookType !== NotebookType.CLASSIC && paragraph.value.input.inputType === 'MARKDOWN';`
`44`	`44`	`let isActionVisible = isClassicNotebook;`
`45`		`- if (!isClassicNotebook && isFindingParagraph && context.state.value.isNotebookOwner) {`
	`45`	`+ if (!isClassicNotebook && isFindingParagraph && !context.state.value.isNotebookReadonly) {`
`46`	`46`	`isActionVisible = true;`
`47`	`47`	`}`
`48`	`48`