fix: handle response body close errors

- Added error handling for closing HTTP response body to improve robustness
- Changed list function to return result of writer flush for better
  error reporting

Signed-off-by: Chmouel Boudjnah <[email protected]>

Author: chmouel

pkg/cmd/tknpac/bootstrap/route.go

@@ -59,7 +59,9 @@ func detectSelfSignedCertificate(ctx context.Context, url string) string {
 	} else if err != nil {
 		return fmt.Sprintf("⚠️ could not connect to the route %s, make sure the pipelines-as-code controller is running", url)
 	}
-	resp.Body.Close()
+	if err := resp.Body.Close(); err != nil {
+		return fmt.Sprintf("⚠️ could not close the response body: %v", err)
+	}
 	return ""
 }
 

pkg/cmd/tknpac/list/list.go

@@ -188,6 +188,5 @@ func list(ctx context.Context, cs *params.Run, opts *cli.PacCliOpts, ioStreams *
 	if err := t.Execute(w, data); err != nil {
 		return err
 	}
-	w.Flush()
-	return nil
+	return w.Flush()
 }