Merge pull request #640 from sm43/fixes-status-report

Author: chmouel

pkg/sort/task_status.go

@@ -9,8 +9,6 @@ import (
 	"github.com/openshift-pipelines/pipelines-as-code/pkg/consoleui"
 	"github.com/openshift-pipelines/pipelines-as-code/pkg/formatting"
 	tektonv1beta1 "github.com/tektoncd/pipeline/pkg/apis/pipeline/v1beta1"
-	corev1 "k8s.io/api/core/v1"
-	knativeapi "knative.dev/pkg/apis"
 )
 
 type tkr struct {
@@ -42,10 +40,6 @@ func (trs taskrunList) Less(i, j int) bool {
 func TaskStatusTmpl(pr *tektonv1beta1.PipelineRun, console consoleui.Interface, statusTemplate string) (string, error) {
 	trl := taskrunList{}
 	outputBuffer := bytes.Buffer{}
-	c := pr.GetStatusCondition().GetCondition(knativeapi.ConditionSucceeded)
-	if c != nil && c.Status != corev1.ConditionTrue {
-		return fmt.Sprintf("PipelineRun has failed to be created: %s", c.Message), nil
-	}
 
 	if len(pr.Status.TaskRuns) == 0 {
 		return "PipelineRun has no taskruns", nil

pkg/sort/task_status_test.go

@@ -8,9 +8,6 @@ import (
 	tektontest "github.com/openshift-pipelines/pipelines-as-code/pkg/test/tekton"
 	tektonv1beta1 "github.com/tektoncd/pipeline/pkg/apis/pipeline/v1beta1"
 	"gotest.tools/v3/assert"
-	corev1 "k8s.io/api/core/v1"
-	knativeapi "knative.dev/pkg/apis"
-	duckv1beta1 "knative.dev/pkg/apis/duck/v1beta1"
 )
 
 func TestStatusTmpl(t *testing.T) {
@@ -58,20 +55,6 @@ func TestStatusTmpl(t *testing.T) {
 			wantRegexp: regexp.MustCompile("PipelineRun has no taskruns"),
 			pr:         tektontest.MakePR("nada", "ns", nil, nil),
 		},
-		{
-			name:       "pipelinerun no apply",
-			wantRegexp: regexp.MustCompile("PipelineRun has failed to be created: looozeuuur"),
-			pr: tektontest.MakePR("pr1", "looz", map[string]*tektonv1beta1.PipelineRunTaskRunStatus{},
-				&duckv1beta1.Status{
-					Conditions: duckv1beta1.Conditions{
-						{
-							Status:  corev1.ConditionFalse,
-							Type:    knativeapi.ConditionSucceeded,
-							Message: "looozeuuur",
-						},
-					},
-				}),
-		},
 	}
 	for _, tt := range tests {
 		t.Run(tt.name, func(t *testing.T) {