Added some prints to check pac watcher issue and removed extra param

Author: savitaashture

cmd/pipelines-as-code-controller/main.go

@@ -32,7 +32,7 @@ func main() {
 	go func() {
 		log.Println("started goroutine to watch configmap changes for controller")
 		c <- struct{}{}
-		if err := run.WatchConfigMapChanges(ctx, run); err != nil {
+		if err := run.WatchConfigMapChanges(ctx); err != nil {
 			log.Fatal("error from WatchConfigMapChanges for controller : ", err)
 		}
 	}()

pkg/params/run.go

@@ -38,7 +38,7 @@ func StringToBool(s string) bool {
 }
 
 // WatchConfigMapChanges watches for provide configmap
-func (r *Run) WatchConfigMapChanges(ctx context.Context, run *Run) error {
+func (r *Run) WatchConfigMapChanges(ctx context.Context) error {
 	r.Clients.Log.Info("Inside WatchConfigMapChanges function")
 	ns := os.Getenv("SYSTEM_NAMESPACE")
 	if ns == "" {
@@ -51,7 +51,7 @@ func (r *Run) WatchConfigMapChanges(ctx context.Context, run *Run) error {
 	if err != nil {
 		return fmt.Errorf("unable to create watcher : %w", err)
 	}
-	if err := run.getConfigFromConfigMapWatcher(ctx, watcher.ResultChan()); err != nil {
+	if err := r.getConfigFromConfigMapWatcher(ctx, watcher.ResultChan()); err != nil {
 		return fmt.Errorf("failed to get defaults : %w", err)
 	}
 	return nil

pkg/reconciler/controller.go

@@ -38,7 +38,7 @@ func NewController() func(context.Context, configmap.Watcher) *controller.Impl {
 		go func() {
 			log.Println("started goroutine to watch configmap changes inside controller reconciler")
 			c <- struct{}{}
-			if err := run.WatchConfigMapChanges(ctx, run); err != nil {
+			if err := run.WatchConfigMapChanges(ctx); err != nil {
 				log.Fatal("error from WatchConfigMapChanges from controller reconciler : ", err)
 			}
 		}()