add a flaky label, deploy operator once, add flakiness ginkgo options #1090
Conversation
openshift-ci
bot
added
the
do-not-merge/work-in-progress
openshift-ci
bot
added
the
approved
|
|
||
| # Label the first node as "on-demand" | ||
| $OC label node "${nodes[0]}" instance-type=on-demand --overwrite | ||
| $OC patch node "${nodes[0]}" --type=merge -p '{"metadata":{"labels":{"instance-type":"on-demand"}}}' |
There was a problem hiding this comment.
So these scripts are selecting two nodes and labeling each as on-demand and spot.
For OCP we have 3 worker nodes.
One thing we could try is to label two nodes as on-demand. This could help with scheduling issues.
I am also curious if this script has issues where 3 of the nodes are control-plane. If I label a control plane node as on-demand, I guess kueue will end up having the workloads try to run on control-plane nodes.
Maybe we should only select worker nodes?
There was a problem hiding this comment.
I see we grab nodes as workers.
I am trying the two worker nodes for on-demand and 1 worker node for spot.
Opened up #1113 to see.
|
/test lint |
rphillips
force-pushed
the
patch_the_node_labels
branch
2 times, most recently
from
9e030f0 to
10afec7
Compare
rphillips
changed the title
openshift-ci
bot
removed
the
do-not-merge/work-in-progress
rphillips
changed the title
rphillips
force-pushed
the
patch_the_node_labels
branch
from
10afec7 to
78e03e9
Compare
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: kannon92, rphillips The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/override ci/prow/test-e2e-4-19 2/3 passed and our CI is in a sorry state. Going to override this for now. |
|
@kannon92: Overrode contexts on behalf of kannon92: ci/prow/test-e2e-4-19 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
@rphillips: all tests passed! Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
2 participants
No description provided.