add linter to detect if changes occur in bindata that will be overwritten

[kannon92]

No description provided.

[openshift-ci]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: kannon92

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [kannon92]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[rphillips]

bindata is largely autogenerated. It should not be manually changed.

[kannon92]

bindata is largely autogenerated. It should not be manually changed.

Correct. I'm trying to avoid the scenario where someone modified that in a PR and we miss it.

[rphillips]

Gotcha. We should also do something like: #871

[rphillips]

We should run sync_manifests so the code isn't duplicated and is consistent on what is outputted.

[sohankunkerkar]

Have you tried using Podman here? For e.g.

.PHONY: check-sync-manifests
check-sync-manifests:
	@podman run --rm \
		-v $(PWD):/workspace:Z \
		-w /workspace \
		python:3.11-slim \
		sh -c " \
			echo 'Installing dependencies...'; \
			apt-get update -qq > /dev/null 2>&1; \
			apt-get install -y -qq git curl jq > /dev/null 2>&1; \
			echo 'Fetching latest kustomize version...'; \
			KUSTOMIZE_VERSION=\$$(curl -s https://api.github.com/repos/kubernetes-sigs/kustomize/releases/latest | jq -r '.tag_name' | sed 's/kustomize\///'); \
			curl -sL https://github.com/kubernetes-sigs/kustomize/releases/download/kustomize%2Fv\$${KUSTOMIZE_VERSION}/kustomize_v\$${KUSTOMIZE_VERSION}_linux_amd64.tar.gz | tar xz -C /usr/local/bin > /dev/null 2>&1; \
			pip install pyyaml requests > /dev/null 2>&1; \
			echo 'Running check_bindata_conflicts.py...'; \
			python3 hack/check_bindata_conflicts.py \
		"

[kannon92]

podman isn't in the CI...

openshift really makes these things difficult.

[sohankunkerkar]

I think you can add podman here (use that src for tests) and see if it helps.

[kannon92]

opened up openshift/release#71154.

[sohankunkerkar]

With https://github.com/openshift/kueue-operator/pull/863/files#r2492538226, you can simply make the following change:

Suggested change

	#!/usr/bin/env -S uv run --with pyyaml --with requests
	#!/usr/bin/env python3

[sohankunkerkar]

/retest

[sohankunkerkar]

/test lint

[openshift-ci]

@kannon92: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name	Commit	Details	Required	Rerun command
ci/prow/test-e2e-4-19	ade1688	link	true	/test test-e2e-4-19
ci/prow/lint	ade1688	link	true	/test lint
ci/prow/test-e2e-4-20	ade1688	link	true	/test test-e2e-4-20
ci/prow/test-e2e-4-18	ade1688	link	true	/test test-e2e-4-18

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.