-
Notifications
You must be signed in to change notification settings - Fork 132
[WIP] migrate ginkgo-tests for router component from openshift-tests-private #664
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
I need to figure out how I can generate bindata.go. I'll share the output of each option I try with integrated binary. |
|
Build OTE binary Options available with the binary Display extension metadata List test cases Run test-suites |
2.1 After OTE migration, the main.go for OTE should be under cmd directory like https://github.com/openshift/machine-api-operator/tree/main/cmd/machine-api-tests-ext or https://github.com/openshift/machine-config-operator/tree/main/cmd/machine-config-tests-ext 2.2 And after moving e2e testing case, it should be under test directory like https://github.com/openshift/machine-api-operator/tree/main/test/e2e/vsphere or https://github.com/openshift/machine-config-operator/tree/main/test/extended
|
Yes, it is. As mentioned during the discussion, I experimented with all available approaches, and the one used in @rioliu-rh's PR appeared to be the most promising and straightforward for migrating test cases from openshift-tests-private. I applied the same approach to the router component, and it worked successfully. This suggests that the same method should be effective for other components as well.
That's right
As discussed multiple times during the OTE migration meetings, it is up to each component team to decide where to place the test cases, manage dependencies, and include the OTE binary. There are no strict guidelines—teams can choose what works best for them. That said, if test dependencies migrated from openshift-tests-private are added to the go.mod file in the root of the target repository, there is a risk of version conflicts with existing dependencies. To avoid this, it's preferable to maintain a standalone subdirectory that contains the migrated test cases and their associated dependencies.
The current goal is to assist component teams in migrating their test cases from openshift-tests-private to their respective source repositories and ensuring they function as expected. If any team has specific requirements that call for a different approach, we’re open to exploring alternatives. Feel free to share any such example, and we can work on it together. |
Yes, this is what I want to figure out one common solution to fix the conflicts with existing dependencies even if we do not care about the directory structure, because whatever the directory structure is, they all need to add dependencies in the root go.mod. If this is not considered, things will more easy. |
Yes, once we begin the actual work, we'll be able to address issues as they come up based on the specific needs. |
- compat_otp is the util folder from otp which is checked into origin
1d60a3f to
e826238
Compare
|
Tried smoke-tests |
|
@jhuttana: The following tests failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
This is a demo PR and is still WIP
/cc @rioliu-rh
/cc @ming1013
/cc @LuboTerifaj
At present facing errors while executing the test-suite due to unavailable test-data which requires proper bindata.go file to be generated.