updated command #1161
Merged
updated command #1161
+1
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jistr
reviewed
Nov 20, 2025
| $ declare -xA PULL_OPENSTACK_CONFIGURATION_DATABASES | ||
| $ for CELL in $(echo $CELLS); do | ||
| > PULL_OPENSTACK_CONFIGURATION_DATABASES[$CELL]=$(oc run mariadb-client-1-$CELL ${MARIADB_RUN_OVERRIDES} -q --image ${MARIADB_IMAGE} -i --rm --restart=Never -- \ | ||
| > PULL_OPENSTACK_CONFIGURATION_DATABASES[$CELL]=$(oc run mariadb-client-1-$CELL --overrides="${RUN_OVERRIDES} $MARIADB_CLIENT_ANNOTATIONS" -q --image ${MARIADB_IMAGE} -i --rm --restart=Never -- \ |
Contributor
There was a problem hiding this comment.
I think instead of this, when we set:
MARIADB_RUN_OVERRIDES="--overrides=${RUN_OVERRIDES} $MARIADB_CLIENT_ANNOTATIONS"
we should instead set
MARIADB_RUN_OVERRIDES="--overrides='${RUN_OVERRIDES}' $MARIADB_CLIENT_ANNOTATIONS"
and leave this line unchanged.
Contributor
There was a problem hiding this comment.
...if i understand things correctly :)
Contributor
Author
There was a problem hiding this comment.
@pinikomarov Do you have any objections to the suggested edit above?
klgill
force-pushed
the
docs-update-ospdo-step
branch
from
929d7d4 to
6d8f54e
Compare
Contributor
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED Approval requirements bypassed by manually added approval. This pull-request has been approved by: The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-merge-bot
bot
merged commit fea9fc3
into
openstack-k8s-operators:main
6 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://issues.redhat.com/browse/OSPRH-19719