fix(block): Change response object to Attachment in a get_attchments tool(#84)

Author: S0okJu

src/openstack_mcp_server/tools/block_storage_tools.py

@@ -3,7 +3,6 @@
 from .base import get_openstack_conn
 from .response.block_storage import (
     Attachment,
-    AttachmentSummary,
     ConnectionInfo,
     Volume,
     VolumeAttachment,
@@ -251,11 +250,16 @@ def get_attachments(
         attachments = []
         for attachment in conn.block_storage.attachments(**filter):
             attachments.append(
-                AttachmentSummary(
+                Attachment(
                     id=attachment.id,
                     instance=attachment.instance,
                     volume_id=attachment.volume_id,
                     status=attachment.status,
+                    connection_info=attachment.connection_info,
+                    attach_mode=attachment.attach_mode,
+                    connector=attachment.connector,
+                    attached_at=attachment.attached_at,
+                    detached_at=attachment.detached_at,
                 )
             )
 

src/openstack_mcp_server/tools/response/block_storage.py

@@ -42,10 +42,3 @@ class Attachment(BaseModel):
     attach_mode: str | None = None
     connection_info: ConnectionInfo | None = None
     connector: str | None = None
-
-
-class AttachmentSummary(BaseModel):
-    id: str
-    instance: str
-    volume_id: str
-    status: str

tests/tools/test_block_storage_tools.py

@@ -752,6 +752,11 @@ def test_get_attachments(self, mock_get_openstack_conn_block_storage):
         mock_attachment.instance = "server-123"
         mock_attachment.volume_id = "vol-123"
         mock_attachment.status = "attached"
+        mock_attachment.connection_info = None
+        mock_attachment.connector = None
+        mock_attachment.attach_mode = None
+        mock_attachment.attached_at = None
+        mock_attachment.detached_at = None
 
         mock_conn.block_storage.attachments.return_value = [mock_attachment]
 
@@ -770,7 +775,11 @@ def test_get_attachments(self, mock_get_openstack_conn_block_storage):
         assert result[0].id == "attach-123"
         assert result[0].instance == "server-123"
         assert result[0].volume_id == "vol-123"
-        assert result[0].status == "attached"
+        assert result[0].attached_at is None
+        assert result[0].detached_at is None
+        assert result[0].attach_mode is None
+        assert result[0].connection_info is None
+        assert result[0].connector is None
 
         # Verify the mock calls
         mock_conn.block_storage.attachments.assert_called_once_with(**filter)