Should we remove tool count assertions from test cases? #77
Closed
paikend
announced in
Announcements
Replies: 1 comment
-
|
Checked our code and there aren't many cases with hardcoded counts. Let's just agree on this internally and wrap up the discussion! |
Beta Was this translation helpful? Give feedback.
0 replies
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Uh oh!
There was an error while loading. Please reload this page.
-
Issue
We have test assertions like:
assert mock_mcp.tool.call_count == 5
Problem
Proposal
Remove call count assertions and focus on testing:
Question
Do these call count assertions provide meaningful value?
If not, let's remove them.
Context
From code review discussion in PR #75
cc @paikend @S0okJu
Beta Was this translation helpful? Give feedback.
All reactions