-
Notifications
You must be signed in to change notification settings - Fork 6
feat: Add tox configuration for OpenStack standard testing #100
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Add macOS system file to gitignore to prevent accidental commits
Add tox.ini following OpenStack project standards to support: - Multiple Python versions testing (py3, py310-313) - Style checking with ruff (pep8 environment) - Code formatting (format environment) - Coverage reporting (cover environment) - Debug support (debug environment) - Virtual environment for arbitrary commands (venv environment) This allows OpenStack contributors to use familiar tox commands while maintaining uv for fast local development.
Add comprehensive development documentation including: - Setup instructions for both uv and tox workflows - uv commands for fast local development - tox commands following OpenStack standards - Testing section with coverage information (85%+) This helps contributors choose their preferred development workflow.
S0okJu
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for adding .DS_Store.
Move tox.ini dependencies to pyproject.toml dependency-groups
and update all tox environments to use 'uv sync' instead of
hardcoded dependency lists. This establishes pyproject.toml
as the single source of truth for dependency management.
Changes:
- Add coverage tools to test dependency group
- Update tox environments to use 'uv sync --group {test|dev}'
- Replace direct commands with 'uv run' for consistency
This maintains OpenStack tox standards while leveraging uv's
speed. All tests passing (156/156, 85% coverage).
halucinor
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
S0okJu
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Summary
Add tox configuration following OpenStack standards while keeping uv for development.
Changes
tox.iniwith OpenStack-style environments.DS_Storeto.gitignoreMotivation
Most OpenStack projects use tox for testing and CI/CD. This allows OpenStack contributors to use familiar tox commands while maintaining uv for fast local development.
Use Cases
tox -e py3ortox -e py310tox -e pep8tox -e cover(85%+ coverage)tox -e venv -- <command>tox -e formatTesting
All environments tested and working:
tox -e py3- 156 tests passedtox -e pep8- All checks passedtox -e cover- 85% coveragetox -e venv- Workinguvworkflow - All commands working#99