API Clarification on createBookmark and getBookmarks

[khers]

In the spec for createBookmark, the position field is the played position in milliseconds, but in the Bookmark response from getBookmarks we only get position in seconds, is this discrepancy in place for backwards compatibility or is there another reason that we are not consistent with units?

[Tolriq]

Anything present that is not touched by OS is usually copy from the original subsonic xmls and docs. It's highly possible there's still some errors when I built it, or it was how the OG server did it. The reference usually for the implementation details is Navidrome that build it's API from the actual last Subsonic code and not their docs.

If it's an error we fix the doc, if it was like that but all do different we amend the doc with clarification.

[paulijar]

According to the OG Subsonic XML schema https://www.subsonic.org/pages/inc/api/schema/subsonic-rest-api-1.16.1.xsd, the position in bookmark is milliseconds. That's also what the example https://www.subsonic.org/pages/inc/api/examples/bookmarks_example_1.xml shows. And even the example in https://opensubsonic.netlify.app/docs/responses/bookmark/ seems to show milliseconds, so it's only the description in the OS API documentation which is at fault.

[Tolriq]

Yes checked my code and I assume ms in both too. If anyone can make a quick PR.

[khers]

I will create a PR later this evening if no one has beat me to it

[khers]

PR here: #176