fixing homogenous check for attributes with non-numeric keys (#1057)

brettmc · web-flow · commit 657975b8aaa9 · 2023-06-28T08:25:27.000+02:00
use reset() instead of trying to get zero array key
diff --git a/Common/Attribute/AttributesBuilder.php b/Common/Attribute/AttributesBuilder.php
@@ -121,7 +121,7 @@ private function isHomogeneous(array $value): bool
         if (count($value) <= 1) {
             return true;
         }
-        $type = gettype($value[0]);
+        $type = gettype(reset($value));
         foreach ($value as $v) {
             if (in_array(gettype($v), self::NUMERICS) && in_array($type, self::NUMERICS)) {
                 continue;

Original file line number	Diff line number	Diff line change
`@@ -121,7 +121,7 @@ private function isHomogeneous(array $value): bool`
`121`	`121`	`if (count($value) <= 1) {`
`122`	`122`	`return true;`
`123`	`123`	`}`
`124`		`- $type = gettype($value[0]);`
	`124`	`+ $type = gettype(reset($value));`
`125`	`125`	`foreach ($value as $v) {`
`126`	`126`	`if (in_array(gettype($v), self::NUMERICS) && in_array($type, self::NUMERICS)) {`
`127`	`127`	`continue;`