fix coding conventions related problems

- Use snake_case when naming variables/resources
- If your variable is controlling a behaviour, use imperative style to
name it e.g. lockdown_default_seclist
- Use simple file names where possible; avoid '-', '' for terraform
files. '' is ok for bash/python.
- Add documentation for new variable in docs/terraformoptions.adoc

Author: kral2

docs/terraformoptions.adoc

@@ -111,4 +111,9 @@ tags = {
 |
 |
 
+|`lockdown_default_seclist`
+|whether to remove all default security rules from the VCN Default Security List
+|true/false
+|true
+
 |===

examples/README.md

@@ -78,7 +78,7 @@ module "vcn" {
   vcn_cidr                 = var.vcn_cidr
   vcn_dns_label            = var.vcn_dns_label
   vcn_name                 = var.vcn_name
-  default_SL_lockdown      = var.default_SL_lockdown
+  lockdown_default_seclist     = var.lockdown_default_seclist
 }
 ```
 

examples/main.tf

@@ -1,4 +1,4 @@
-# Copyright (c) 2019, 2020 Oracle Corporation and/or affiliates.  All rights reserved.
+# Copyright (c) 2019, 2021, Oracle Corporation and/or affiliates.
 # Licensed under the Universal Permissive License v 1.0 as shown at https://oss.oracle.com/licenses/upl/
 
 module "vcn" {
@@ -25,7 +25,7 @@ module "vcn" {
 
   vcn_name = "vcn"
 
-  default_SL_lockdown = "true"
+  lockdown_default_seclist = true
 
   tags = {
     environment = "dev"

examples/variables.tf

@@ -1,4 +1,4 @@
-# Copyright (c) 2019, 2020 Oracle Corporation and/or affiliates.  All rights reserved.
+# Copyright (c) 2019, 2021, Oracle Corporation and/or affiliates.
 # Licensed under the Universal Permissive License v 1.0 as shown at https://oss.oracle.com/licenses/upl
 
 # provider identity parameters
@@ -83,7 +83,7 @@ variable "vcn_name" {
   type        = string
 }
 
-variable "default_SL_lockdown" {
+variable "lockdown_default_seclist" {
   description = "whether to remove all default security rules from the VCN Default Security List"
   default     = true
   type        = bool

nat.tf

@@ -9,7 +9,7 @@ groupings:
     - vcn_cidr
     - vcn_name
     - vcn_dns_label
-    - default_SL_lockdown
+    - lockdown_default_seclist
 
 variables:
   region:
@@ -49,7 +49,7 @@ variables:
     required: true
     default: vcn
 
-  default_SL_lockdown:
+  lockdown_default_seclist:
     title: Enable VCN Default Security List Lockdown
     type: string
     required: false

schema.yaml

@@ -66,7 +66,7 @@ variable "vcn_name" {
   type        = string
 }
 
-variable "default_SL_lockdown" {
+variable "lockdown_default_seclist" {
   description = "whether to remove all default security rules from the VCN Default Security List"
   default     = true
   type        = bool

servicegateway.tf

@@ -1,4 +1,4 @@
-# Copyright (c) 2019, 2020 Oracle Corporation and/or affiliates.  All rights reserved.
+# Copyright (c) 2019, 2021, Oracle Corporation and/or affiliates.
 # Licensed under the Universal Permissive License v 1.0 as shown at https://oss.oracle.com/licenses/upl/
 
 resource "oci_core_vcn" "vcn" {
@@ -9,30 +9,3 @@ resource "oci_core_vcn" "vcn" {
 
   freeform_tags = var.tags
 }
-
-resource "oci_core_internet_gateway" "ig" {
-  compartment_id = var.compartment_id
-  display_name   = var.label_prefix == "none" ? "internet-gateway" : "${var.label_prefix}-internet-gateway"
-
-  freeform_tags = var.tags
-
-  vcn_id = oci_core_vcn.vcn.id
-
-  count = var.internet_gateway_enabled == true ? 1 : 0
-}
-
-resource "oci_core_route_table" "ig" {
-  compartment_id = var.compartment_id
-  display_name   = var.label_prefix == "none" ? "internet-route" : "${var.label_prefix}-internet-route"
-
-  freeform_tags = var.tags
-
-  route_rules {
-    destination       = local.anywhere
-    network_entity_id = oci_core_internet_gateway.ig[0].id
-  }
-
-  vcn_id = oci_core_vcn.vcn.id
-
-  count = var.internet_gateway_enabled == true ? 1 : 0
-}

variables.tf

@@ -1,17 +1,17 @@
-# Copyright (c) 2021 Oracle Corporation and/or affiliates.
+# Copyright (c) 2021, Oracle Corporation and/or affiliates.
 # Licensed under the Universal Permissive License v 1.0 as shown at https://oss.oracle.com/licenses/upl/
 
 # VCN default Security List Lockdown
-// See Issue #22 for 
+// See Issue #22 for the reasoning
 resource "oci_core_default_security_list" "lockdown" {
   // If variable is true, removes all rules from default security list
-  count                      = var.default_SL_lockdown == true ? 1 : 0
+  count                      = var.lockdown_default_seclist == true ? 1 : 0
   manage_default_resource_id = oci_core_vcn.vcn.default_security_list_id
 }
 
 resource "oci_core_default_security_list" "restore_default" {
   // If variable is false, restore all default rules to default security list
-  count                      = var.default_SL_lockdown == false ? 1 : 0
+  count                      = var.lockdown_default_seclist == false ? 1 : 0
   manage_default_resource_id = oci_core_vcn.vcn.default_security_list_id
 
   egress_security_rules {