Erroneous roundabout highway=* analysis ?

[cquest]

analyser_osmosis_roundabout_level.py incorrectly detect higher level xxx_link connected to a round-about as incorrect value fur the roundabout highway=* tag.

Example: https://www.openstreetmap.org/way/29504953

2 primary_link are connected to a secondary roundabout, but the wiki is clear about keeping highway=secondary in this case, and not promoting the roundabout to highway=primary

See: https://wiki.openstreetmap.org/wiki/Tag:junction=roundabout#Selection_of_the_right_highway_tag

I also think the second example in the wiki is not handled properly.

[frodrigo]

Clearly not what Osmose implement.

Osmose: "It must match the highest level of connected routes, except motorway and trunk."

Maybe the wiki definition have changed since it was implemented.

The wiki case 4 is also not valid for country where bicycle are not allowed on trunk, it breaks the network connectivity for bicycle routing.

In the wiki case 2, the secondary also ends on the roundabout like the primary...

[cquest]

The definition where a higher hierarchy road crosses or just ends at the roundabout seems to appear in 2012: https://wiki.openstreetmap.org/w/index.php?title=Tag:junction%3Droundabout&direction=next&oldid=769786

A global logic would need to count the number of ways of each highway=* type (merging link with their mother type), with a 0.5 factor for oneway.
If the total for a type of highway=* is less than 2 it means it does not go through the roundabout.
It is not perfect, but would deal with most cases.