Ensure Ending conversation test case works

[olabini]

Ensure that the test case in https://github.com/otrv4/pidgin-otrng/wiki/Test-Case---Ending-a-conversation works correctly. In the process of doing that, fill in the documentation in the wiki with more details where necessary.

[claucece]

Take into account that a conversation can also be started or ended from the config panel:

[giovaneliberato]

Potential bug found in Test Case 2 - Configuration Panel ("Know fingerprints" tab), test online version, responder ends the private conversation

The last ensure wasn't true for some tests, needs investigation

Ensure that "Start private conversation" is enabled, while "End private conversation" is not disabled

[claucece]

I found some bugs around here, so I'm opening this again. Manly:

Test Case 1 - Conversation window

Running the test (online version, initiator ends the private conversation)

• Start Pidgin
• Double clic on "bob@localhost" to open a conversation window with Bob
• Click the "OTR" menu
• Ensure that "Start private conversation" is enabled, while "End private conversation" and "Authenticate buddy" are not enabled
• Click on "Start private conversation"
• Ensure that it says "Verified conversation started" or "Unverified conversation started." in the conversation window with bob@ (Message depends on context but it's not relevant)
• Type "Hello, Bob" and press enter.
• Ensure that the message shows up in the conversation window with bob@

• Switch to bob's conversation window with alice@
• Ensure that it says "Verified conversation started" or "Unverified conversation started."
• Ensure that the "Hello, Bob" message shows up in that window
• Type "Oh, hi Alice" and press enter.
• Ensure that the message shows up in the conversation window with alice@

• Switch to alice's conversation window with bob@
• Ensure that the "Oh, hi Alice" message shows up in that window
• Press the "OTR" menu, and then "End private conversation"
• Ensure that it says "Private conversation lost."
• Ensure the OTR conversation status displays "Not Private"
• Click the "OTR" menu
• Ensure that "Start private conversation" is enabled, while "End private conversation" and "Authenticate buddy" are not enabled

• Switch to bob's conversation window with alice@
• Ensure that it says "Private conversation lost."
• Ensure the OTR conversation status displays "Finished"
• Click the "OTR" menu
• Ensure that "Start private conversation" is enabled, while "End private conversation" and "Authenticate buddy" are not enabled ---------> Here, the "End private conversation" is enabled and if you clicked it, pidgin will crash.

---

The same happens for Running the test (online version, responder ends the private conversation), Running the test (offline version, initiator ends the private conversation), Running the test (offline version, responder ends the private conversation) and Running the test (offline version, initiator ends the private conversation when responder went offline).

[claucece]

Related to #57

[claucece]

Thanks for the work @giovaneliberato :)

[giovaneliberato]

hmm, I'll take a look at this now