Skip to content

Commit 9df6ae4

Browse files
author
kodsurfer
committed
#94 rename OvsSet to OvsDataSet
Signed-off-by: kodsurfer <[email protected]>
1 parent 95e9dd2 commit 9df6ae4

22 files changed

+167
-167
lines changed

cache/cache_test.go

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -2037,7 +2037,7 @@ func BenchmarkPopulate2UpdateArray(b *testing.B) {
20372037
b.ResetTimer()
20382038
for n := 0; n < b.N; n++ {
20392039
for i := 0; i < numRows; i++ {
2040-
updatedRow := ovsdb.Row(map[string]interface{}{"array": ovsdb.OvsSet{GoSet: updateSet}})
2040+
updatedRow := ovsdb.Row(map[string]interface{}{"array": ovsdb.OvsDataSet{GoSet: updateSet}})
20412041
err := tc.Populate2(ovsdb.TableUpdates2{
20422042
"Open_vSwitch": {
20432043
"foo": &ovsdb.RowUpdate2{

client/api_test.go

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1944,7 +1944,7 @@ func TestAPIWait(t *testing.T) {
19441944
{
19451945
Column: "up",
19461946
Function: ovsdb.ConditionNotEqual,
1947-
Value: ovsdb.OvsSet{GoSet: []interface{}{true}},
1947+
Value: ovsdb.OvsDataSet{GoSet: []interface{}{true}},
19481948
},
19491949
},
19501950
Until: string(ovsdb.WaitConditionNotEqual),

client/client_test.go

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -493,7 +493,7 @@ var schema = `{
493493
}
494494
}`
495495

496-
func testOvsSet(t *testing.T, set interface{}) ovsdb.OvsSet {
496+
func testOvsSet(t *testing.T, set interface{}) ovsdb.OvsDataSet {
497497
oSet, err := ovsdb.NewOvsSet(set)
498498
assert.Nil(t, err)
499499
return oSet

database/inmemory/inmemory_test.go

Lines changed: 8 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -586,7 +586,7 @@ func TestMultipleOps(t *testing.T) {
586586
ovsdb.NewCondition("_uuid", ovsdb.ConditionEqual, ovsdb.UUID{GoUUID: bridgeUUID}),
587587
},
588588
Row: ovsdb.Row{
589-
"ports": ovsdb.OvsSet{GoSet: []interface{}{ovsdb.UUID{GoUUID: "port1"}, ovsdb.UUID{GoUUID: "port10"}}},
589+
"ports": ovsdb.OvsDataSet{GoSet: []interface{}{ovsdb.UUID{GoUUID: "port1"}, ovsdb.UUID{GoUUID: "port10"}}},
590590
"external_ids": ovsdb.OvsMap{GoMap: map[interface{}]interface{}{"key1": "value1", "key10": "value10"}},
591591
},
592592
}
@@ -612,7 +612,7 @@ func TestMultipleOps(t *testing.T) {
612612
Op: ovsdb.OperationMutate,
613613
Mutations: []ovsdb.Mutation{
614614
*ovsdb.NewMutation("external_ids", ovsdb.MutateOperationInsert, ovsdb.OvsMap{GoMap: map[interface{}]interface{}{"keyA": "valueA"}}),
615-
*ovsdb.NewMutation("ports", ovsdb.MutateOperationDelete, ovsdb.OvsSet{GoSet: []interface{}{ovsdb.UUID{GoUUID: "port1"}, ovsdb.UUID{GoUUID: "port10"}}}),
615+
*ovsdb.NewMutation("ports", ovsdb.MutateOperationDelete, ovsdb.OvsDataSet{GoSet: []interface{}{ovsdb.UUID{GoUUID: "port1"}, ovsdb.UUID{GoUUID: "port10"}}}),
616616
},
617617
}
618618
ops = append(ops, op)
@@ -625,7 +625,7 @@ func TestMultipleOps(t *testing.T) {
625625
Op: ovsdb.OperationMutate,
626626
Mutations: []ovsdb.Mutation{
627627
*ovsdb.NewMutation("external_ids", ovsdb.MutateOperationDelete, ovsdb.OvsMap{GoMap: map[interface{}]interface{}{"key10": "value10"}}),
628-
*ovsdb.NewMutation("ports", ovsdb.MutateOperationInsert, ovsdb.OvsSet{GoSet: []interface{}{ovsdb.UUID{GoUUID: "port1"}}}),
628+
*ovsdb.NewMutation("ports", ovsdb.MutateOperationInsert, ovsdb.OvsDataSet{GoSet: []interface{}{ovsdb.UUID{GoUUID: "port1"}}}),
629629
},
630630
}
631631
ops = append(ops, op2)
@@ -642,19 +642,19 @@ func TestMultipleOps(t *testing.T) {
642642
bridgeUUID: &ovsdb.RowUpdate2{
643643
Modify: &ovsdb.Row{
644644
"external_ids": ovsdb.OvsMap{GoMap: map[interface{}]interface{}{"keyA": "valueA", "key10": "value10"}},
645-
"ports": ovsdb.OvsSet{GoSet: []interface{}{ovsdb.UUID{GoUUID: "port10"}}},
645+
"ports": ovsdb.OvsDataSet{GoSet: []interface{}{ovsdb.UUID{GoUUID: "port10"}}},
646646
},
647647
Old: &ovsdb.Row{
648648
"_uuid": ovsdb.UUID{GoUUID: bridgeUUID},
649649
"name": "a_bridge_to_nowhere",
650650
"external_ids": ovsdb.OvsMap{GoMap: map[interface{}]interface{}{"key1": "value1", "key10": "value10"}},
651-
"ports": ovsdb.OvsSet{GoSet: []interface{}{ovsdb.UUID{GoUUID: "port1"}, ovsdb.UUID{GoUUID: "port10"}}},
651+
"ports": ovsdb.OvsDataSet{GoSet: []interface{}{ovsdb.UUID{GoUUID: "port1"}, ovsdb.UUID{GoUUID: "port10"}}},
652652
},
653653
New: &ovsdb.Row{
654654
"_uuid": ovsdb.UUID{GoUUID: bridgeUUID},
655655
"name": "a_bridge_to_nowhere",
656656
"external_ids": ovsdb.OvsMap{GoMap: map[interface{}]interface{}{"key1": "value1", "keyA": "valueA"}},
657-
"ports": ovsdb.OvsSet{GoSet: []interface{}{ovsdb.UUID{GoUUID: "port1"}}},
657+
"ports": ovsdb.OvsDataSet{GoSet: []interface{}{ovsdb.UUID{GoUUID: "port1"}}},
658658
},
659659
},
660660
},
@@ -941,7 +941,7 @@ func TestCheckIndexesWithReferentialIntegrity(t *testing.T) {
941941
Op: ovsdb.OperationInsert,
942942
UUID: ovsUUID,
943943
Row: ovsdb.Row{
944-
"manager_options": ovsdb.OvsSet{GoSet: []interface{}{ovsdb.UUID{GoUUID: managerUUID}}},
944+
"manager_options": ovsdb.OvsDataSet{GoSet: []interface{}{ovsdb.UUID{GoUUID: managerUUID}}},
945945
},
946946
},
947947
{
@@ -978,7 +978,7 @@ func TestCheckIndexesWithReferentialIntegrity(t *testing.T) {
978978
Table: "Open_vSwitch",
979979
Op: ovsdb.OperationUpdate,
980980
Row: ovsdb.Row{
981-
"manager_options": ovsdb.OvsSet{GoSet: []interface{}{ovsdb.UUID{GoUUID: managerUUID2}}},
981+
"manager_options": ovsdb.OvsDataSet{GoSet: []interface{}{ovsdb.UUID{GoUUID: managerUUID2}}},
982982
},
983983
Where: []ovsdb.Condition{
984984
ovsdb.NewCondition("_uuid", ovsdb.ConditionEqual, ovsdb.UUID{GoUUID: ovsUUID}),

mapper/mapper_test.go

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1049,7 +1049,7 @@ func TestMapperMutation(t *testing.T) {
10491049
}
10501050
}
10511051

1052-
func testOvsSet(t *testing.T, set interface{}) ovsdb.OvsSet {
1052+
func testOvsSet(t *testing.T, set interface{}) ovsdb.OvsDataSet {
10531053
oSet, err := ovsdb.NewOvsSet(set)
10541054
assert.Nil(t, err)
10551055
return oSet

ovsdb/bindings.go

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -116,7 +116,7 @@ func OvsToNativeSlice(baseType string, ovsElem interface{}) (interface{}, error)
116116
naType := NativeTypeFromAtomic(baseType)
117117
var nativeSet reflect.Value
118118
switch ovsSet := ovsElem.(type) {
119-
case OvsSet:
119+
case OvsDataSet:
120120
nativeSet = reflect.MakeSlice(reflect.SliceOf(naType), 0, len(ovsSet.GoSet))
121121
for _, v := range ovsSet.GoSet {
122122
nv, err := OvsToNativeAtomic(baseType, v)
@@ -152,7 +152,7 @@ func OvsToNative(column *ColumnSchema, ovsElem interface{}) (interface{}, error)
152152
switch naType.Kind() {
153153
case reflect.Ptr:
154154
switch ovsSet := ovsElem.(type) {
155-
case OvsSet:
155+
case OvsDataSet:
156156
if len(ovsSet.GoSet) > 1 {
157157
return nil, fmt.Errorf("expected a slice of len =< 1, but got a slice with %d elements", len(ovsSet.GoSet))
158158
}
@@ -233,7 +233,7 @@ func NativeToOvs(column *ColumnSchema, rawElem interface{}) (interface{}, error)
233233
case TypeUUID:
234234
return UUID{GoUUID: rawElem.(string)}, nil
235235
case TypeSet:
236-
var ovsSet OvsSet
236+
var ovsSet OvsDataSet
237237
if column.TypeObj.Key.Type == TypeUUID {
238238
ovsSlice := []interface{}{}
239239
if _, ok := rawElem.([]string); ok {
@@ -250,7 +250,7 @@ func NativeToOvs(column *ColumnSchema, rawElem interface{}) (interface{}, error)
250250
} else {
251251
return nil, fmt.Errorf("uuid slice was neither []string or *string")
252252
}
253-
ovsSet = OvsSet{GoSet: ovsSlice}
253+
ovsSet = OvsDataSet{GoSet: ovsSlice}
254254

255255
} else {
256256
var err error

ovsdb/condition_test.go

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -71,7 +71,7 @@ func TestConditionMarshalUnmarshalJSON(t *testing.T) {
7171
},
7272
{
7373
"test set",
74-
Condition{"foo", ConditionExcludes, OvsSet{GoSet: []interface{}{"foo", "bar", "baz"}}},
74+
Condition{"foo", ConditionExcludes, OvsDataSet{GoSet: []interface{}{"foo", "bar", "baz"}}},
7575
`[ "foo", "excludes", ["set",["foo", "bar", "baz"]] ]`,
7676
false,
7777
},
@@ -83,7 +83,7 @@ func TestConditionMarshalUnmarshalJSON(t *testing.T) {
8383
},
8484
{
8585
"test uuid set",
86-
Condition{"foo", ConditionExcludes, OvsSet{GoSet: []interface{}{UUID{GoUUID: "foo"}, UUID{GoUUID: "bar"}}}},
86+
Condition{"foo", ConditionExcludes, OvsDataSet{GoSet: []interface{}{UUID{GoUUID: "foo"}, UUID{GoUUID: "bar"}}}},
8787
`[ "foo", "excludes", ["set",[["named-uuid", "foo"], ["named-uuid", "bar"]]] ]`,
8888
false,
8989
},

ovsdb/encoding_test.go

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -160,7 +160,7 @@ func TestSet(t *testing.T) {
160160
assert.Nil(t, err)
161161
assert.JSONEqf(t, tt.expected, string(jsonStr), "they should be equal\n")
162162

163-
var res OvsSet
163+
var res OvsDataSet
164164
err = json.Unmarshal(jsonStr, &res)
165165
assert.Nil(t, err)
166166
assert.Equal(t, set.GoSet, res.GoSet, "they should have the same elements\n")

ovsdb/mutation_test.go

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -65,7 +65,7 @@ func TestMutationMarshalUnmarshalJSON(t *testing.T) {
6565
},
6666
{
6767
"test set",
68-
Mutation{"foo", MutateOperationInsert, OvsSet{GoSet: []interface{}{"foo", "bar", "baz"}}},
68+
Mutation{"foo", MutateOperationInsert, OvsDataSet{GoSet: []interface{}{"foo", "bar", "baz"}}},
6969
`[ "foo", "insert", ["set",["foo", "bar", "baz"]] ]`,
7070
false,
7171
},
@@ -77,7 +77,7 @@ func TestMutationMarshalUnmarshalJSON(t *testing.T) {
7777
},
7878
{
7979
"test uuid set",
80-
Mutation{"foo", MutateOperationInsert, OvsSet{GoSet: []interface{}{UUID{GoUUID: "foo"}, UUID{GoUUID: "bar"}}}},
80+
Mutation{"foo", MutateOperationInsert, OvsDataSet{GoSet: []interface{}{UUID{GoUUID: "foo"}, UUID{GoUUID: "bar"}}}},
8181
`[ "foo", "insert", ["set",[["named-uuid", "foo"], ["named-uuid", "bar"]]] ]`,
8282
false,
8383
},

ovsdb/named_uuid.go

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -117,7 +117,7 @@ func expandNamedUUID(column *ColumnSchema, value interface{}, namedUUIDs map[str
117117
}
118118
}
119119
} else if keyType == TypeUUID {
120-
if ovsSet, ok := value.(OvsSet); ok {
120+
if ovsSet, ok := value.(OvsDataSet); ok {
121121
for i, s := range ovsSet.GoSet {
122122
if newUUID, ok := expandNamedUUIDAtomic(keyType, s, namedUUIDs); ok {
123123
ovsSet.GoSet[i] = newUUID

0 commit comments

Comments
 (0)