-
Notifications
You must be signed in to change notification settings - Fork 17
Mention JDK requirements in README #84
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: develop
Are you sure you want to change the base?
Conversation
|
Thanks for your interest in palantir/javapoet, @Marcono1234! Before we can accept your pull request, you need to sign our contributor license agreement - just visit https://cla.palantir.com/ and follow the instructions. Once you sign, I'll automatically update this pull request. |
I had hoped a CLA will not be necessary. I will probably sign it though, but I have some questions which I wrote to [email protected] a few days ago, and will wait for an answer first. |
|
Thanks! Let me know if you don’t hear back by next week, I can make sure things move along. I’m ooto until next Thursday, so my response time may be a bit slow in the meantime. |
|
It seems I haven't gotten any response yet. Maybe the e-mail address I had sent my questions from was a bit unusual, but the e-mail subject and body shouldn't have triggered any spam detection on Palantir's side I hope. |
|
This PR has been automatically marked as stale because it has not been touched in the last 14 days. If you'd like to keep it open, please leave a comment or add the 'long-lived' label, otherwise it'll be closed in 7 days. |
|
So far I still haven't gotten a response to my CLA questions I had sent per mail. If a company thinks they need a CLA, they should at least specify how they use the provided data, how they protect it and which of it (if any) will be publicly visible. |
|
This PR has been automatically marked as stale because it has not been touched in the last 14 days. If you'd like to keep it open, please leave a comment or add the 'long-lived' label, otherwise it'll be closed in 7 days. |
|
I assume eventually this PR here will then be closed as well, just like #85 and #87 (and other Lots of other large companies don't require a CLA on GitHub (see also this blog post), or make it easier to sign one, require less data (especially no handwritten signature) and make it clear what the data is used for, how it is protected and who will have access to it (and whether it is e.g. publicly exposed on GitHub). I guess someone else has to implement these improvements and fixes then. |
Before this PR
The class files of this project are compiled with Java 17 as target version, but it is currently not documented.
After this PR
The minimum JDK version is documented
Not sure if for the generated code a minimum JDK version can be specified as well. It probably mostly depends on what builder methods users are calling. For example if they use
TypeSpec#recordBuilder, then the generated code can not be compiled with JDK 8.