Skip to content

Conversation

@Marcono1234
Copy link
Contributor

Before this PR

The class files of this project are compiled with Java 17 as target version, but it is currently not documented.

After this PR

The minimum JDK version is documented

Not sure if for the generated code a minimum JDK version can be specified as well. It probably mostly depends on what builder methods users are calling. For example if they use TypeSpec#recordBuilder, then the generated code can not be compiled with JDK 8.

@palantirtech
Copy link
Member

Thanks for your interest in palantir/javapoet, @Marcono1234! Before we can accept your pull request, you need to sign our contributor license agreement - just visit https://cla.palantir.com/ and follow the instructions. Once you sign, I'll automatically update this pull request.

carterkozak
carterkozak previously approved these changes Oct 2, 2024
@carterkozak carterkozak dismissed their stale review October 2, 2024 13:55

pending cla

@Marcono1234
Copy link
Contributor Author

pending cla

I had hoped a CLA will not be necessary. I will probably sign it though, but I have some questions which I wrote to [email protected] a few days ago, and will wait for an answer first.

@carterkozak
Copy link
Contributor

Thanks! Let me know if you don’t hear back by next week, I can make sure things move along. I’m ooto until next Thursday, so my response time may be a bit slow in the meantime.

@Marcono1234
Copy link
Contributor Author

Marcono1234 commented Oct 24, 2024

It seems I haven't gotten any response yet. Maybe the e-mail address I had sent my questions from was a bit unusual, but the e-mail subject and body shouldn't have triggered any spam detection on Palantir's side I hope.

@stale
Copy link

stale bot commented Jun 27, 2025

This PR has been automatically marked as stale because it has not been touched in the last 14 days. If you'd like to keep it open, please leave a comment or add the 'long-lived' label, otherwise it'll be closed in 7 days.

@stale stale bot added the stale label Jun 27, 2025
@Marcono1234
Copy link
Contributor Author

So far I still haven't gotten a response to my CLA questions I had sent per mail. If a company thinks they need a CLA, they should at least specify how they use the provided data, how they protect it and which of it (if any) will be publicly visible.

@stale stale bot removed the stale label Jun 29, 2025
@stale
Copy link

stale bot commented Oct 18, 2025

This PR has been automatically marked as stale because it has not been touched in the last 14 days. If you'd like to keep it open, please leave a comment or add the 'long-lived' label, otherwise it'll be closed in 7 days.

@stale stale bot added the stale label Oct 18, 2025
@Marcono1234
Copy link
Contributor Author

I assume eventually this PR here will then be closed as well, just like #85 and #87 (and other is:closed label:stale PRs).

Lots of other large companies don't require a CLA on GitHub (see also this blog post), or make it easier to sign one, require less data (especially no handwritten signature) and make it clear what the data is used for, how it is protected and who will have access to it (and whether it is e.g. publicly exposed on GitHub).

I guess someone else has to implement these improvements and fixes then.
For what its worth, the Palantir CLA includes "8. Submissions on Behalf of Third Parties", so I would not mind if someone who signed the CLA picks up my commits and creates a PR with them (in case that is permitted).

@stale stale bot removed the stale label Oct 25, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants