Skip to content

chore: updates to support standalone mode - #1868

Merged
nikhilsinhaparseable merged 2 commits into
parseablehq:mainfrom
nikhilsinhaparseable:single-binary-changes
Nov 20, 2026
Merged

nikhilsinhaparseable merged 2 commits into
parseablehq:mainfrom
nikhilsinhaparseable:single-binary-changes

Conversation

@nikhilsinhaparseable

@nikhilsinhaparseable nikhilsinhaparseable commented Nov 19, 2026 •

Copy link
Copy Markdown
Member
  • prevent standalone requests from forwarding to other live nodes in cluster
  • query local staging data through arrow flight
  • handle local-store metadata directories safely
  • bound object-store upload and stream-sync concurrency

RetriggerView in GreptileConfidence Score: 5/5

This re-review adds no new merge blockers beyond the findings already reported.

Summary

Updates standalone mode and limits storage work.

  • Standalone queries and cluster lookups stay inside the local process.
  • Standalone startup skips the cluster-secret prompt.
  • Library callers can use the authorized log-context query helper.
  • Local stream discovery skips .targets and .keystone metadata folders.
  • Object-store uploads and stream syncs share process-wide limits.

Reviews (7) · Last reviewed commit: "fix review comments" · Reviewed by Greptile

- prevent standalone requests from forwarding to other live nodes in cluster
- query local staging data through arrow flight
- handle local-store metadata directories safely
- use atomic LocalFS metadata writes
- bound object-store upload and stream-sync concurrency
Comment thread src/storage/localfs.rs Resolved
@greptile-apps

greptile-apps Bot commented Nov 19, 2026

Copy link
Copy Markdown

Comments Outside Diff

These findings could not be posted inline.

  • P1 Metadata writes can corrupt files src/storage/localfs.rs:387 ▶

    Metadata writes can corrupt files. Replacing the temporary-file write with fs::write truncates the live file before writing its replacement, including on Linux. Snapshot updates write .stream.json through this path while queries read and immediately parse that same file. A query during the write can receive empty or incomplete JSON and fail; a failed write can leave the saved metadata damaged. Keep the old file intact until a complete replacement is ready, using a replacement operation that also works safely on Windows.

@nikhilsinhaparseable
nikhilsinhaparseable merged commit e23df0f into parseablehq:main Nov 20, 2026
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants