DF behaviour: Allow zero-horizon windows/views #13
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This aims at supporting zero-horizon windows in OpenStream programs. The behaviour should be semantically equivalent to not referencing the respective stream at all in the task creation statement.
@a-pop commit 46ab217 removes an assertion in
wstream_df_resolve_n_dependences(). This allows my programs to run but it will obviously cause problems. In particular, I can no longer use thepeekclause, instead having to resort to a zero-burstinput.@a-pop There is an odd zero-decrease call to
tdecrease_n()after I modifiedwstream_df_resolve_dependences()and__built_in_wstream_df_prepare_dataso I added a guard totdecrease_n(). Is this okay? There's probably a better fix once we know the reason for that call.@Richard549 This bypasses trace state changes on both
tdecrease_n()andwstream_df_resolve_dependences()on early exists, can you please check if this is okay?