Skip to content

Commit 825afa3

Browse files
committed
fix(submodule): remove better-sqlite3 submodule and related configuration
1 parent 00cc6a9 commit 825afa3

File tree

3 files changed

+6
-13
lines changed

3 files changed

+6
-13
lines changed

.gitmodules

Lines changed: 0 additions & 3 deletions
This file was deleted.

CLAUDE.md

Lines changed: 6 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -59,8 +59,7 @@ node-sqlite/
5959
│ ├── node_mem.h # Memory management utilities
6060
│ ├── util.h # Node.js utility functions
6161
│ └── ... # Other Node.js internal headers
62-
├── third-party/ # Reference implementations for compatibility
63-
│ └── better-sqlite3/ # better-sqlite3 package for API reference (submodule)
62+
├── ../better-sqlite3/ # better-sqlite3 for API reference (optional, clone separately)
6463
├── ../node/ # Node.js repository for reference (optional, clone separately)
6564
├── scripts/
6665
│ └── sync-from-node.js # Automated sync from Node.js repository
@@ -100,12 +99,11 @@ node-sqlite/
10099
- Loads native binding and exports typed interfaces
101100
- Handles Symbol.dispose integration
102101

103-
**Vendored Reference Implementations** (`third-party/`):
102+
**External Reference Implementations** (optional, clone separately):
104103

105-
- **`third-party/better-sqlite3/`**: Reference implementation for better-sqlite3 API compatibility
106-
- Contains full source code, documentation, and comprehensive test suite
107-
- Used for API reference when implementing better-sqlite3 drop-in replacement features
108-
- Test suite provides validation that our implementation matches expected behavior
104+
- **`../better-sqlite3/`**: Reference implementation for better-sqlite3 API compatibility
105+
- Clone from https://github.com/WiseLibs/better-sqlite3 if needed for API reference
106+
- Used when implementing better-sqlite3 drop-in replacement features
109107

110108
### Documentation Structure
111109

@@ -219,8 +217,7 @@ This approach reduces test brittleness while ensuring error handling works corre
219217
- **Main implementation** is in `src/sqlite_impl.{h,cpp}` (ported from Node.js)
220218
- **Shims** in `src/shims/` provide Node.js internal API compatibility
221219
- **User functions** are implemented in `src/user_function.{h,cpp}`
222-
- **Use `third-party/better-sqlite3/` for API reference** when implementing better-sqlite3 compatibility
223-
- **Validate against `third-party/better-sqlite3/test/`** to ensure drop-in replacement behavior
220+
- **Use `../better-sqlite3/` for API reference** when implementing better-sqlite3 compatibility (clone separately if needed)
224221

225222
### Testing Requirements
226223

third-party/better-sqlite3

Lines changed: 0 additions & 1 deletion
This file was deleted.

0 commit comments

Comments
 (0)