feat(repository): add RepositoryFactory interface to improve extensibility

Author: roxblnfk

src/Bootstrap.php

@@ -9,6 +9,8 @@
 use Internal\DLoad\Module\Common\Internal\ObjectContainer;
 use Internal\DLoad\Module\Common\OperatingSystem;
 use Internal\DLoad\Module\Common\Stability;
+use Internal\DLoad\Module\Repository\Internal\GitHub\Factory as GithubRepositoryFactory;
+use Internal\DLoad\Module\Repository\RepositoryProvider;
 use Internal\DLoad\Service\Container;
 
 /**
@@ -93,6 +95,11 @@ public function withConfig(
         $this->container->bind(Architecture::class);
         $this->container->bind(OperatingSystem::class);
         $this->container->bind(Stability::class);
+        $this->container->bind(
+            RepositoryProvider::class,
+            static fn(Container $container): RepositoryProvider => (new RepositoryProvider())
+                ->addRepositoryFactory($container->get(GithubRepositoryFactory::class)),
+        );
 
         return $this;
     }

src/Module/Downloader/Downloader.php

@@ -16,7 +16,7 @@
 use Internal\DLoad\Module\Downloader\Task\DownloadTask;
 use Internal\DLoad\Module\Repository\AssetInterface;
 use Internal\DLoad\Module\Repository\ReleaseInterface;
-use Internal\DLoad\Module\Repository\RepositoryInterface;
+use Internal\DLoad\Module\Repository\Repository;
 use Internal\DLoad\Module\Repository\RepositoryProvider;
 use Internal\DLoad\Service\Destroyable;
 use Internal\DLoad\Service\Logger;
@@ -115,11 +115,11 @@ public function download(
      *
      * Fetches and filters releases from the repository based on stability and version constraints.
      *
-     * @param RepositoryInterface $repository Repository to process
+     * @param Repository $repository Repository to process
      * @param DownloadContext $context Download context information
      * @return \Closure(): ReleaseInterface Closure that returns the selected release
      */
-    private function processRepository(RepositoryInterface $repository, DownloadContext $context): \Closure
+    private function processRepository(Repository $repository, DownloadContext $context): \Closure
     {
         return function () use ($repository, $context): ReleaseInterface {
             $this->logger->info(

src/Module/Repository/Collection/CompositeRepository.php

@@ -4,7 +4,7 @@
 
 namespace Internal\DLoad\Module\Repository\Collection;
 
-use Internal\DLoad\Module\Repository\RepositoryInterface;
+use Internal\DLoad\Module\Repository\Repository;
 
 /**
  * Collection of repositories that also implements the repository interface.
@@ -23,15 +23,15 @@
  * @internal
  * @psalm-internal Internal\DLoad\Module
  */
-final class CompositeRepository implements RepositoryInterface
+final class CompositeRepository implements Repository
 {
     /**
-     * @var array<RepositoryInterface>
+     * @var array<Repository>
      */
     private array $repositories;
 
     /**
-     * @param array<RepositoryInterface> $repositories List of repositories to include
+     * @param array<Repository> $repositories List of repositories to include
      */
     public function __construct(array $repositories)
     {

src/Module/Repository/Internal/GitHub/Factory.php

@@ -4,26 +4,31 @@
 
 namespace Internal\DLoad\Module\Repository\Internal\GitHub;
 
+use Internal\DLoad\Module\Common\Config\Embed\Repository as RepositoryConfig;
 use Internal\DLoad\Module\Common\Config\GitHub as GitHubConfig;
+use Internal\DLoad\Module\Repository\RepositoryFactory;
+use Internal\DLoad\Module\Repository\Repository;
 use Symfony\Component\HttpClient\HttpClient;
 use Symfony\Contracts\HttpClient\HttpClientInterface;
 
 /**
  * @internal
  * @psalm-internal Internal\DLoad\Module\Repository
  */
-final class Factory
+final class Factory implements RepositoryFactory
 {
     public function __construct(
         private readonly GitHubConfig $config,
     ) {}
 
-    /**
-     * @param non-empty-string $uri Package name in format "owner/repository" or full URL
-     */
-    public function create(string $uri): GitHubRepository
+    public function supports(RepositoryConfig $config): bool
     {
-        $uri = \parse_url($uri, PHP_URL_PATH) ?? $uri;
+        return \strtolower($config->type) === 'github';
+    }
+
+    public function create(RepositoryConfig $config): GitHubRepository
+    {
+        $uri = \parse_url($config->uri, PHP_URL_PATH) ?? $config->uri;
         [$org, $repo] = \array_slice(\explode('/', $uri), -2);
 
         return new GitHubRepository($org, $repo, $this->createClient());

src/Module/Repository/Internal/GitHub/GitHubRepository.php

@@ -5,7 +5,7 @@
 namespace Internal\DLoad\Module\Repository\Internal\GitHub;
 
 use Internal\DLoad\Module\Repository\Collection\ReleasesCollection;
-use Internal\DLoad\Module\Repository\RepositoryInterface;
+use Internal\DLoad\Module\Repository\Repository;
 use Internal\DLoad\Service\Destroyable;
 use Symfony\Component\HttpClient\HttpClient;
 use Symfony\Contracts\HttpClient\Exception\ExceptionInterface;
@@ -18,7 +18,7 @@
  * @internal
  * @psalm-internal Internal\DLoad\Module\Repository\GitHub
  */
-final class GitHubRepository implements RepositoryInterface, Destroyable
+final class GitHubRepository implements Repository, Destroyable
 {
     private const URL_RELEASES = 'https://api.github.com/repos/%s/releases';
 

src/Module/Repository/Internal/Release.php

@@ -9,7 +9,7 @@
 use Internal\DLoad\Module\Common\Stability;
 use Internal\DLoad\Module\Repository\Collection\AssetsCollection;
 use Internal\DLoad\Module\Repository\ReleaseInterface;
-use Internal\DLoad\Module\Repository\RepositoryInterface;
+use Internal\DLoad\Module\Repository\Repository;
 
 /**
  * @internal
@@ -32,7 +32,7 @@ abstract class Release implements ReleaseInterface
      * @param non-empty-string $version
      */
     public function __construct(
-        protected RepositoryInterface $repository,
+        protected Repository $repository,
         string $name,
         protected string $version,
         ?Stability $stability = null,
@@ -43,7 +43,7 @@ public function __construct(
         $this->stability = $stability ?? $this->parseStability($version);
     }
 
-    public function getRepository(): RepositoryInterface
+    public function getRepository(): Repository
     {
         return $this->repository;
     }

src/Module/Repository/ReleaseInterface.php

@@ -29,9 +29,9 @@ interface ReleaseInterface
     /**
      * Returns the repository this release belongs to.
      *
-     * @return RepositoryInterface The parent repository
+     * @return Repository The parent repository
      */
-    public function getRepository(): RepositoryInterface;
+    public function getRepository(): Repository;
 
     /**
      * Returns Composer's compatible "pretty" release version.

…odule/Repository/RepositoryInterface.php src/Module/Repository/Repository.phpsrc/Module/Repository/RepositoryInterface.php renamed to src/Module/Repository/Repository.php src/Module/Repository/RepositoryInterface.php renamed to src/Module/Repository/Repository.php

@@ -18,7 +18,7 @@
  * $filteredReleases = $releases->satisfies('^2.0.0')->sortByVersion();
  * ```
  */
-interface RepositoryInterface
+interface Repository
 {
     /**
      * Returns the unique identifier of the repository.

src/Module/Repository/RepositoryFactory.php

@@ -0,0 +1,30 @@
+<?php
+
+declare(strict_types=1);
+
+namespace Internal\DLoad\Module\Repository;
+
+use Internal\DLoad\Module\Common\Config\Embed\Repository as RepositoryConfig;
+
+/**
+ * Interface for repository factory implementations.
+ *
+ * Each repository type (GitHub, GitLab, etc.) should have its own factory
+ * implementation that creates repository instances from configuration.
+ */
+interface RepositoryFactory
+{
+    /**
+     * Determines if this factory can create a repository for the given config.
+     */
+    public function supports(RepositoryConfig $config): bool;
+
+    /**
+     * Creates a repository instance from the given config.
+     *
+     * @param RepositoryConfig $config Repository configuration
+     * @return Repository Created repository instance
+     * @throws \RuntimeException If repository cannot be created
+     */
+    public function create(RepositoryConfig $config): Repository;
+}

src/Module/Repository/RepositoryProvider.php

@@ -4,14 +4,13 @@
 
 namespace Internal\DLoad\Module\Repository;
 
-use Internal\DLoad\Module\Common\Config\Embed\Repository;
-use Internal\DLoad\Module\Repository\Internal\GitHub\Factory as GithubFactory;
+use Internal\DLoad\Module\Common\Config\Embed\Repository as RepositoryConfig;
 
 /**
  * Factory service for creating repository instances from configuration.
  *
- * Handles the creation of appropriate repository implementations based on
- * the repository type specified in the configuration.
+ * Uses registered repository factories to create appropriate repository
+ * implementations based on the repository type.
  *
  * ```php
  * // Get the RepositoryProvider service
@@ -26,25 +25,33 @@
  */
 final class RepositoryProvider
 {
+    /** @var RepositoryFactory[] $factories */
+    private array $factories = [];
+
     /**
-     * @param GithubFactory $githubFactory Factory for creating GitHub repository instances
+     * Adds a repository factory to the provider.
      */
-    public function __construct(
-        private readonly GithubFactory $githubFactory,
-    ) {}
+    public function addRepositoryFactory(RepositoryFactory $factory): self
+    {
+        $this->factories[] = $factory;
+        return $this;
+    }
 
     /**
      * Creates a repository instance based on the provided configuration.
      *
-     * @param Repository $config Repository configuration
-     * @return RepositoryInterface Created repository instance
-     * @throws \RuntimeException When an unknown repository type is specified
+     * @param RepositoryConfig $config Repository configuration
+     * @return Repository Created repository instance
+     * @throws \RuntimeException When no factory supports the repository type
      */
-    public function getByConfig(Repository $config): RepositoryInterface
+    public function getByConfig(RepositoryConfig $config): Repository
     {
-        return match (\strtolower($config->type)) {
-            'github' => $this->githubFactory->create($config->uri),
-            default => throw new \RuntimeException("Unknown repository type `$config->type`."),
-        };
+        foreach ($this->factories as $factory) {
+            if ($factory->supports($config)) {
+                return $factory->create($config);
+            }
+        }
+
+        throw new \RuntimeException("No factory found for repository type `$config->type`.");
     }
 }