Fixed code review. Added php docblock

Author: haphan

src/Metric/v1/Gnocchi/Api.php

@@ -33,7 +33,8 @@ public function getResource(): array
             'path'   => $this->pathPrefix.'/resource/{type}/{id}',
             'method' => 'GET',
             'params' => [
-                'id' => $this->params->idUrl('resource'),
+                'id'   => $this->params->idUrl('resource'),
+                'type' => $this->params->resourceType(),
             ],
         ];
     }

src/Metric/v1/Gnocchi/Models/Resource.php

@@ -86,7 +86,6 @@ public function retrieve()
         $this->populateFromResponse($response);
     }
 
-
     /**
      * @param string $metric
      *

src/Metric/v1/Gnocchi/Models/ResourceType.php

@@ -1,6 +1,6 @@
 <?php declare(strict_types=1);
 
-namespace OpenStack\Metric\v1\Gnocchi;
+namespace OpenStack\Metric\v1\Gnocchi\Models;
 
 use OpenStack\Common\Resource\OperatorResource;
 

src/Metric/v1/Gnocchi/Params.php

@@ -45,7 +45,7 @@ public function headerContentType(): array
         ];
     }
 
-    public function idUrl($type)
+    public function idUrl($type): array
     {
         return [
             'required'    => true,
@@ -54,7 +54,7 @@ public function idUrl($type)
         ];
     }
 
-    public function granularity()
+    public function granularity(): array
     {
         return [
             'location'    => self::QUERY,
@@ -63,7 +63,7 @@ public function granularity()
         ];
     }
 
-    public function aggregation()
+    public function aggregation(): array
     {
         return [
             'location'    => self::QUERY,

src/Metric/v1/Gnocchi/Service.php

@@ -16,11 +16,23 @@
  */
 class Service extends AbstractService
 {
+    /**
+     * Retrieves a collection of \OpenStack\Metric\v1\Gnocchi\Models\ResourceType type in a generator format.
+     *
+     * @return \Generator
+     */
     public function listResourceTypes(): \Generator
     {
         return $this->model(ResourceType::class)->enumerate($this->api->getResourceTypes(), []);
     }
 
+    /**
+     * Retrieves a collection of \OpenStack\Metric\v1\Gnocchi\Models\Resource type in a generator format.
+     *
+     * @param array $options {@see \OpenStack\Metric\v1\Gnocchi\Api::getResources}
+     *
+     * @return \Generator
+     */
     public function listResources(array $options = []): \Generator
     {
         $this->injectGenericType($options);
@@ -29,20 +41,31 @@ public function listResources(array $options = []): \Generator
     }
 
     /**
+     * Retrieves a Resource object and populates its unique identifier object. This operation will not perform a GET or
+     * HEAD request by default; you will need to call retrieve() if you want to pull in remote state from the API.
+     *
      * @param array $options
      *
-     * @return \OpenStack\Metric\v1\Gnocchi\Models\Resource
+     * @return Resource
      */
-    public function getResource(array $options = []): \OpenStack\Metric\v1\Gnocchi\Models\Resource
+    public function getResource(array $options = []): Resource
     {
         $this->injectGenericType($options);
 
+        /** @var Resource $resource */
         $resource = $this->model(Resource::class);
         $resource->populateFromArray($options);
 
         return $resource;
     }
 
+    /**
+     * Retrieves a collection of \OpenStack\Metric\v1\Gnocchi\Models\Resource type in a generator format.
+     *
+     * @param array $options {@see \OpenStack\Metric\v1\Gnocchi\Api::searchResources}
+     *
+     * @return \Generator
+     */
     public function searchResources(array $options = []): \Generator
     {
         $this->injectGenericType($options);
@@ -64,19 +87,41 @@ public function searchResources(array $options = []): \Generator
         return $this->model(Resource::class)->enumerate($this->api->searchResources(), $options);
     }
 
-    public function getMetric($id): Metric
+    /**
+     * Retrieves a Metric object and populates its unique identifier object. This operation will not perform a GET or
+     * HEAD request by default; you will need to call retrieve() if you want to pull in remote state from the API.
+     *
+     * @param string $id
+     *
+     * @return Metric
+     */
+    public function getMetric(string $id): Metric
     {
+        /** @var Metric $metric */
         $metric = $this->model(Metric::class);
         $metric->populateFromArray(['id' => $id]);
 
         return $metric;
     }
 
+    /**
+     * Retrieves a collection of Metric type in a generator format.
+     *
+     * @param array $options {@see \OpenStack\Metric\v1\Gnocchi\Api::getMetrics}
+     *
+     * @return \Generator
+     */
     public function listMetrics(array $options = []): \Generator
     {
         return $this->model(Metric::class)->enumerate($this->api->getMetrics(), $options);
     }
 
+    /**
+     * If options does not have type, this will inject $options['type'] = 'generic'
+     *
+     * @internal
+     * @param array $options
+     */
     private function injectGenericType(array &$options)
     {
         if (empty($options) || !isset($options['type'])) {