gen_stub: Conditionally include zend_attributes.h to arginfo based on usage

[dkulyk]

Conditionally include zend_attributes.h only when attributes are actually used.

Currently, zend_attributes.h must be explicitly included in C source files even when only common attributes (e.g. #[\Deprecated]) are needed. This introduces unnecessary coupling between extensions and attribute internals.

This change removes the requirement to manually include the header for common attributes, reducing boilerplate and avoiding unnecessary dependencies.

It does not affect behavior or runtime — only improves developer ergonomics and compilation dependencies.

[kocsismate]

Another complication: some functions are declared conditionally:

php-src/ext/ldap/ldap.stub.php

Line 631 in 4f02d15

function ldap_connect(?string $uri = null, int $port = 389, string $wallet = UNKNOWN, #[\SensitiveParameter] string $password = UNKNOWN, int $auth_mode = GSLC_SSL_NO_AUTH): LDAP\Connection|false {}

And the related attributes are declared with the same conditions: e.g.

php-src/ext/ldap/ldap_arginfo.h

Line 710 in 4f02d15

#if defined(HAVE_ORALDAP)

So ideally, any includes should be wrapped within the necessary conditions.

There are already a few parameters which are passed to all generating methods (e.g. allConstInfos or $declaredStrings). I don't mind adding yet another one. Alternatively, you could create a DTO containing these classes.

And there's already a Context class which stores global state, but I wouldn't put a file based info into this one.

[dkulyk]

Reworked. Header dependencies are collected during generation and passed down as a parameter, so the includes come from the code that emits the declaration rather than from scanning the output.

All four points covered: collection in a HeaderDependencies instance owned by FileInfo, zend_constants.h and zend_enum.h alongside zend_attributes.h, and includes carrying the same version and preprocessor guards as the code needing them. Several conditions for one header merge into #if (A) || (B); a header also needed unconditionally is emitted without a guard.

The third commit drops manual includes that became redundant.

[kocsismate]

Thank you!