[CLEANUP] Fix some Scrutinizer warnings (#289)

Author: oliverklee

src/Composer/ModuleFinder.php

@@ -234,7 +234,7 @@ public function findGeneralConfiguration(): array
             $configurationSets[] = $extra['phplist/core']['configuration'];
         }
 
-        return array_replace_recursive(...$configurationSets);
+        return /** @scrutinizer ignore-call */ array_replace_recursive(...$configurationSets);
     }
 
     /**

src/Composer/ScriptHandler.php

@@ -205,10 +205,16 @@ public static function createBundleConfiguration(Event $event)
      * @param string $contents
      *
      * @return void
+     *
+     * @throws \RuntimeException
      */
     private static function createAndWriteFile(string $path, string $contents)
     {
         $fileHandle = fopen($path, 'wb');
+        if ($fileHandle === false) {
+            throw new \RuntimeException('The file "' . $path . '" could not be opened for writing.', 1519851153);
+        }
+
         fwrite($fileHandle, $contents);
         fclose($fileHandle);
     }

src/Core/Bootstrap.php

@@ -74,11 +74,11 @@ protected function __clone()
      */
     public static function getInstance(): Bootstrap
     {
-        if (static::$instance === null) {
-            static::$instance = new static();
+        if (self::$instance === null) {
+            self::$instance = new static();
         }
 
-        return static::$instance;
+        return self::$instance;
     }
 
     /**
@@ -90,7 +90,7 @@ public static function getInstance(): Bootstrap
      */
     public static function purgeInstance()
     {
-        static::$instance = null;
+        self::$instance = null;
     }
 
     /**
@@ -140,9 +140,9 @@ private function isDebugEnabled(): bool
      * @SuppressWarnings("PHPMD.ExitExpression")
      * @SuppressWarnings("PHPMD.Superglobals")
      *
-     * @return Bootstrap fluent interface
+     * @return Bootstrap|null fluent interface
      */
-    public function ensureDevelopmentOrTestingEnvironment(): Bootstrap
+    public function ensureDevelopmentOrTestingEnvironment()
     {
         $usesProxy = isset($_SERVER['HTTP_CLIENT_IP']) || isset($_SERVER['HTTP_X_FORWARDED_FOR']);
         $isOnCli = PHP_SAPI === 'cli' || PHP_SAPI === 'cli-server';

src/Core/Environment.php

@@ -59,8 +59,8 @@ private function __construct()
      */
     public static function validateEnvironment(string $environment)
     {
-        if (!in_array($environment, static::$validEnvironments, true)) {
-            $environmentsText = '"' . implode('", ', static::$validEnvironments) . '"';
+        if (!in_array($environment, self::$validEnvironments, true)) {
+            $environmentsText = '"' . implode('", ', self::$validEnvironments) . '"';
             throw new \UnexpectedValueException(
                 '$environment must be one of ' . $environmentsText . ', but actually was: "' . $environment . '"',
                 1499112172

src/Domain/Repository/Identity/AdministratorTokenRepository.php

@@ -47,6 +47,6 @@ public function removeExpired(): int
         $queryBuilder = $this->getEntityManager()->createQueryBuilder();
         $queryBuilder->delete(AdministratorToken::class, 'token')->where('token.expiry <= CURRENT_TIMESTAMP()');
 
-        return $queryBuilder->getQuery()->execute();
+        return (int)$queryBuilder->getQuery()->execute();
     }
 }