lake: add incremental updates 420#22783
lake: add incremental updates 420#22783lilin90 wants to merge 3 commits intopingcap:feature/preview-cloud-lakefrom
Conversation
lilin90
added
translation/no-need
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
ti-chi-bot
Bot
added
the
size/XXL
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request adds documentation for numerous new geospatial and JSON functions, updates the geospatial overview to specify GEOMETRY/GEOGRAPHY support, and introduces a "Query Result Defaults" section to the worksheet guide. It also refines the STRIP_NULL_VALUE documentation. Feedback suggests using standard blockquote formatting for notes, applying backticks to technical terms like float32, and correcting minor grammatical inconsistencies for better alignment with the style guide.
| :::note | ||
| - The function reports an error if the two input GEOMETRY objects have different SRIDs. | ||
| ::: |
There was a problem hiding this comment.
For consistency with other documentation files in this repository, please use the standard blockquote format for notes instead of the :::note container.
| :::note | |
| - The function reports an error if the two input GEOMETRY objects have different SRIDs. | |
| ::: | |
| > **Note:** | |
| > | |
| > The function reports an error if the two input GEOMETRY objects have different SRIDs. |
|
|
||
| > **Note:** | ||
| > | ||
| > - Geometry: If no bounding box is provided, GEOMETRY coordinates are not normalized to a specific bounding box. Instead, the center point values are mapped to the full float32 domain, and then encoded into the Hilbert index. |
There was a problem hiding this comment.
Technical terms like float32 should be enclosed in backticks for better readability and consistency with the style guide.
| > - Geometry: If no bounding box is provided, GEOMETRY coordinates are not normalized to a specific bounding box. Instead, the center point values are mapped to the full float32 domain, and then encoded into the Hilbert index. | |
| > - Geometry: If no bounding box is provided, GEOMETRY coordinates are not normalized to a specific bounding box. Instead, the center point values are mapped to the full `float32` domain, and then encoded into the Hilbert index. |
References
- Code snippets, command names, options, and paths should be in backticks. (link)
| > **Note:** | ||
| > | ||
| > If the Geometry don't have a SRID, a default value 4326 will be returned. | ||
| > - If the Geometry don't have a SRID, a default value `0` will be returned. |
There was a problem hiding this comment.
Corrected grammar and terminology: 'geometry' should be lowercase for consistency, 'does not' is preferred over 'don't', and 'an SRID' is correct because 'S' is pronounced with a leading vowel sound ('ess').
| > - If the Geometry don't have a SRID, a default value `0` will be returned. | |
| > - If the geometry does not have an SRID, a default value `0` will be returned. |
Add documentation for the new SYSTEM$SET_CACHE_CAPACITY call and wire it into the TOC. Create tidb-cloud-lake/sql/set-cache-capacity.md describing syntax, notes, and examples. Expand system.caches doc (columns, cache list, example queries) to describe cache names, units, and usage; include note that disk_cache_column_data cannot be adjusted. Add Tag Operations sections to ALTER TABLE and ALTER VIEW docs (syntax and examples for SET/UNSET TAG). Also update an example ROLE_ARN value in alter-table.md.
|
@lilin90: The following test failed, say
Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
1 participant
What is changed, added or deleted? (Required)
Incremental Lake docs updates till 4/20
Note
Renamed
/tidb-cloud-lake/sql/rename-database.mdto/tidb-cloud-lake/sql/alter-database.md.Which TiDB version(s) do your changes apply to? (Required)
Tips for choosing the affected version(s):
By default, CHOOSE MASTER ONLY so your changes will be applied to the next TiDB major or minor releases. If your PR involves a product feature behavior change or a compatibility change, CHOOSE THE AFFECTED RELEASE BRANCH(ES) AND MASTER.
For details, see tips for choosing the affected versions.
What is the related PR or file link(s)?
Do your changes match any of the following descriptions?