-
Notifications
You must be signed in to change notification settings - Fork 203
sync-diff-inspector: Update README #848
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
|
Adding the "do-not-merge/release-note-label-needed" label because no release-note block was detected, please follow our release note process to remove it. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
[FORMAT CHECKER NOTIFICATION] Notice: To remove the 📖 For more info, you can check the "Contribute Code" section in the development guide. |
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/hold We should finish the CD changes firstly. |
|
/unhold |
|
@wuhuizuo @joechenrh what is the status and plan for this? |
|
Hi @dveeden, currently, the code has only moved the master branch of tiflow. After we manually cherry-pick to all other release branch in tiflow, we can totally move to that repo. |
|
@joechenrh I think it would be good to add a note about this to the README. This PR seems ok for that. Even after this is merged the repo can still be used for cherry-picks etc. I want to avoid that others create new PRs for the master branch for this repo without knowing that it has moved elsewhere. I do see a |
Differernt from tiflow and other repo, all the release versions are based on the latest master branch at that time. |
What problem does this PR solve?
Issue Number: close #xxx
What is changed and how it works?
Check List
Tests
Code changes
Side effects
Related changes