Skip to content

Conversation

@joechenrh
Copy link
Contributor

What problem does this PR solve?

Issue Number: close #xxx

What is changed and how it works?

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Code changes

  • Has exported function/method change
  • Has exported variable/fields change
  • Has interface methods change
  • Has persistent data change

Side effects

  • Possible performance regression
  • Increased code complexity
  • Breaking backward compatibility

Related changes

  • Need to cherry-pick to the release branch
  • Need to update the documentation
  • Need to be included in the release note

@ti-chi-bot
Copy link

ti-chi-bot bot commented Feb 8, 2025

Adding the "do-not-merge/release-note-label-needed" label because no release-note block was detected, please follow our release note process to remove it.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@ti-chi-bot
Copy link

ti-chi-bot bot commented Feb 8, 2025

[FORMAT CHECKER NOTIFICATION]

Notice: To remove the do-not-merge/needs-linked-issue label, please provide the linked issue number on one line in the PR body, for example: Issue Number: close #123 or Issue Number: ref #456.

📖 For more info, you can check the "Contribute Code" section in the development guide.

@ti-chi-bot
Copy link

ti-chi-bot bot commented Feb 8, 2025

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign breezewish for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@wuhuizuo
Copy link
Contributor

wuhuizuo commented Feb 8, 2025

/hold

We should finish the CD changes firstly.

ref PingCAP-QE/artifacts#548.

@wuhuizuo
Copy link
Contributor

/unhold

@dveeden
Copy link
Contributor

dveeden commented Jul 29, 2025

@wuhuizuo @joechenrh what is the status and plan for this?

@joechenrh
Copy link
Contributor Author

Hi @dveeden, currently, the code has only moved the master branch of tiflow. After we manually cherry-pick to all other release branch in tiflow, we can totally move to that repo.

@dveeden
Copy link
Contributor

dveeden commented Jul 30, 2025

@joechenrh I think it would be good to add a note about this to the README. This PR seems ok for that. Even after this is merged the repo can still be used for cherry-picks etc.

I want to avoid that others create new PRs for the master branch for this repo without knowing that it has moved elsewhere.

I do see a release-5.2 branch, but I don't see anything like release-8.5. So how do release branches work for this repo?

@joechenrh
Copy link
Contributor Author

So how do release branches work for this repo?

Differernt from tiflow and other repo, all the release versions are based on the latest master branch at that time.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants