-
Notifications
You must be signed in to change notification settings - Fork 6.1k
stats: avoid creating pseudo stats table when dumping stats delta (#62887) #64565
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: release-8.5
Are you sure you want to change the base?
stats: avoid creating pseudo stats table when dumping stats delta (#62887) #64565
Conversation
Signed-off-by: Wenqi Mou <[email protected]>
Signed-off-by: Wenqi Mou <[email protected]>
|
This cherry pick PR is for a release branch and has not yet been approved by triage owners. To merge this cherry pick:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
0xPoe
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks! ![]()
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## release-8.5 #64565 +/- ##
================================================
Coverage ? 76.4701%
================================================
Files ? 1654
Lines ? 456109
Branches ? 0
================================================
Hits ? 348787
Misses ? 86214
Partials ? 21108
Flags with carried forward coverage won't be shown. Click here to find out more.
🚀 New features to boost your workflow:
|
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: 0xPoe, time-and-fate The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
[LGTM Timeline notifier]Timeline:
|

This is an automated cherry-pick of #62887
What problem does this PR solve?
Issue Number: close #62590
Problem Summary:
based on issue reproduction and memory analysis , the majority of memory waste comes from creating pseudo stats table when doing needDumpStatsDelta check, we can simply use a lightweight approach to solve it without changing too much of the code.
This is happening during millions table workload while dumping stats happens frequently, in the issue mentioned smaller table size should also have same effect but I was unable to reproduce, maybe query creates only limited number of pseudo stats and quickly got GC, whereas dump stats happened for all tables in a burst, causing memory pressure.
What changed and how does it work?
Check List
Tests
Side effects
Documentation
Release note
Please refer to Release Notes Language Style Guide to write a quality release note.