Repository navigation
Conversation
Co-Authored-By: GPT-6.1 Sol <noreply@openai.com>
ApprovabilityVerdict: Needs Human Approval Macroscope's review found this PR requires human approval — This small visual fix changes the Android terminal preview's default font from You can add or adjust custom eligibility rules. Learn more. |
|
Warning Review limit reachedOnly developers with an assigned seat can use this organization's usage-based review budget, and seats here are assigned manually. Ask an admin to assign a seat, or change the review continuation mode in Billing. Next included review available in 5 minutes. View limit details
No actionable comments were generated in the recent review. ℹ️ Recent review info
Walkthrough
Merge Risk:
|
|
Note Written by thanks @only21mil. your one-line fix correctly uses android's system monospace family while retaining menlo on ios. i preserved it unchanged and merged current main ( verification on this tree:
current-head android rendering remains unverified: this vm has no attached android device, and the device tool reports access disabled. historical evidence from your original android 16 run, inspected and reuploaded here. these are matching 10.5 pt dark-theme captures of the original fix, not new captures of the merged head. |
|
Note Written by Verified in a real dev environmentno changed behavior could be exercised on this linux vm. this is an unverifiable result, not a runtime pass. i read the description, discussion, commit authors and one-line diff, and fetched exact head runtime prerequisite checks this run: the test-t3-mobile skill requires stopping verification when device access is unavailable. no dev server, metro, browser substitute, mocks, fixtures or provider turns were started. no code changes were made. git.cafe reports 28 successful checks, zero pending and zero failing; those checks do not prove native rendering. Not verified
no new before/after screenshots or recording could be captured. the historical images in the description and previous comment are not current-run evidence. verification needs device access enabled and an android device, followed by matching main/head captures and exercising the neighboring settings controls. |
|
Note Written by Verified on Android emulator (API 35) against a real dev serververified head created the real settings > appearance > terminal now renders its actual sample in monospace. the matching before/after images use t3 code dark and 10.5 pt. for the before capture, i temporarily loaded the unchanged preview component from base the font-size slider changed 10.5 to 12.5 pt and resized the monospace sample. disabling custom size restored the default and hid the slider; enabling it restored the control at 10.5 pt. the selected dark theme and custom preference survived an app restart. adjacent text and code previews retained their respective proportional and monospace fonts. the animated recording shows the slider change and disabling custom sizing; re-enabling was also exercised separately. no production change or push was needed. the working tree is clean at the original head. git.cafe reports 28 successful checks, zero pending and zero failing; no new static checks were run for this verification-only pass. Not verified
screenshots were inspected at full resolution. the exported recording was inspected and its uploaded player playback and seeking were checked. this verifies the android change and does not supply the separate human approval requested by the existing review. |






Problem
On Android, Settings > Appearance > Terminal uses
Menlofor its font-size preview. That Apple font is not available on Android, so the sample falls back to proportional text. Users cannot judge terminal text size from a monospace sample.This preview sets its own inline
fontFamilyand does not use thefont-monoclass, so the Android monospace token never reaches it.Change
Use Android's system
monospacefamily for the terminal preview. KeepMenloon other platforms. The existing font-size, line-height, theme colors, and sample text stay the same.Selecting the Android family directly avoids changing the iOS preview to the code preview's different font family.
Scope and approval
This qualifies for the small obvious bug exception. It corrects the font used by an existing preview, adds no settings, and changes no terminal behavior. No related bug issue was found.
Verification
The base still hard-codes
MenloinTerminalAppearancePreview. Live open and closed PR searches found no competing fix for this preview. The font-customization change in #21987 only touchesTextAppearancePreviewin this file.Focused checks passed:
On an Android 16 emulator, I ran base and candidate with production JavaScript and opened Settings > Appearance > Terminal with T3 Code dark and a 10.5 pt custom terminal font size. Base shows proportional text; the candidate shows monospace text.
Before, base at 10.5 pt:
After, candidate at the same size and theme:
No test was added. This is a purely visual fix, and the repository's verification guidance asks for before/after captures instead of a UI test.
Not checked:
Menlo.Prior PRs: #4609 by Harshith Goka fixed Android's CSS monospace family. This corrects an inline family that bypasses that fix. #5428 by Julius Marminge added the current terminal sample, which this change preserves. #21987 by Jake Leventhal adds font customization in a different preview; no code is copied from it. No closed PR for this same fix was found.
Production fix, PR description and images written with GPT-6.1 Sol in T3 Code Nightly.
🤖 Generated with GPT-6.1 Sol in T3 Code Nightly