Skip to content

Commit 7b2fac0

Browse files
authored
Check dependencies in Makefile (#169)
1 parent e9d33fd commit 7b2fac0

File tree

2 files changed

+19
-14
lines changed

2 files changed

+19
-14
lines changed

Makefile

Lines changed: 18 additions & 13 deletions
Original file line numberDiff line numberDiff line change
@@ -17,39 +17,44 @@ pip: venv
1717
venv:
1818
python3 -m venv --upgrade-deps .venv
1919

20-
# the following commands can only be used when `make` was executed successfully
21-
# TODO issue-135: print a hint on the console to execute `make`
22-
jupyter:
20+
# General check for any tool in .venv/bin, based on the target name
21+
check-%:
22+
@if [ ! -f .venv/bin/$* ]; then \
23+
echo "Tool '$*' not found in .venv/bin. Please run 'make' (or 'make install-dev') to install dependencies"; \
24+
exit 1; \
25+
fi
26+
27+
jupyter: check-jupyter
2328
.venv/bin/jupyter notebook --no-browser
2429

25-
mkdocs:
30+
mkdocs: check-mkdocs
2631
.venv/bin/mkdocs serve
2732

28-
format:
33+
format: check-black
2934
.venv/bin/black .
3035

31-
type-check:
36+
type-check: check-mypy
3237
.venv/bin/mypy src/
3338

34-
lint:
39+
lint: check-ruff
3540
.venv/bin/ruff check --fix
3641
markdownlint --fix '**/*.md'
3742

38-
pytest:
43+
pytest: check-pytest
3944
.venv/bin/pytest
4045

41-
assignment-0:
46+
assignment-0: check-pytest
4247
.venv/bin/pytest tests/htwgnlp/test_python_basics.py
4348

44-
assignment-1:
49+
assignment-1: check-pytest
4550
.venv/bin/pytest tests/htwgnlp/test_preprocessing.py
4651

47-
assignment-2:
52+
assignment-2: check-pytest
4853
.venv/bin/pytest tests/htwgnlp/test_features.py
4954
.venv/bin/pytest tests/htwgnlp/test_logistic_regression.py
5055

51-
assignment-3:
56+
assignment-3: check-pytest
5257
.venv/bin/pytest tests/htwgnlp/test_naive_bayes.py
5358

54-
assignment-4:
59+
assignment-4: check-pytest
5560
.venv/bin/pytest tests/htwgnlp/test_embeddings.py

docs/getting_started.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -154,7 +154,7 @@ Jupyter is now accessible at <http://localhost:8888/>.
154154
If you want, you can bring up the lecture notes on your local machine.
155155

156156
```sh
157-
make docs
157+
make mkdocs
158158
```
159159

160160
The lecture notes are now accessible at <http://localhost:8000/>.

0 commit comments

Comments
 (0)