Skip to content

Conversation

@wesleybl
Copy link
Member

During the installation of plone.app.multilingual, checks if plone.volto is installed. If it is, adds the volto.blocks behavior to LRF.

I didn't add plone.volto as a test dependency.

Closes plone/Products.CMFPlone#4238

@mister-roboto
Copy link

@wesleybl thanks for creating this Pull Request and helping to improve Plone!

TL;DR: Finish pushing changes, pass all other checks, then paste a comment:

@jenkins-plone-org please run jobs

To ensure that these changes do not break other parts of Plone, the Plone test suite matrix needs to pass, but it takes 30-60 min. Other CI checks are usually much faster and the Plone Jenkins resources are limited, so when done pushing changes and all other checks pass either start all Jenkins PR jobs yourself, or simply add the comment above in this PR to start all the jobs automatically.

Happy hacking!

@wesleybl
Copy link
Member Author

@mauritsvanrees @davisagli @gforcada It seems the native namespace is causing problems in Plone 6.2.

During the installation of `plone.app.multilingual`, checks if `plone.volto` is installed.
If it is, adds the volto.blocks behavior to LRF.
@wesleybl
Copy link
Member Author

The problem might be that the plone.app.multilingual version of Plone 6.1 still uses legacy namespaces. It wouldn't be compatible for testing with the native namespace-based Plone 6.2 products. Perhaps it's not worth testing this branch with Plone 6.2.

@wesleybl
Copy link
Member Author

@jenkins-plone-org please run jobs

@wesleybl
Copy link
Member Author

In fact, it would be necessary to modify all the Plone 6.1 packages that are tested with Plone 6.2 😲

@davisagli
Copy link
Member

@wesleybl Plone 6.2 uses the master branch of this package. We should remove 6.2 from the testing matrix for the 8.x branch. /cc @gforcada

@wesleybl
Copy link
Member Author

@jenkins-plone-org please run jobs

@erral erral self-requested a review November 29, 2025 14:53
Copy link
Member

@erral erral left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@erral
Copy link
Member

erral commented Nov 29, 2025

We should forward-port this to main too @wesleybl

Copy link
Member

@davisagli davisagli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this makes sense. We do need a PR for the master branch too.

@wesleybl
Copy link
Member Author

wesleybl commented Dec 2, 2025

@jenkins-plone-org please run jobs

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants