-
-
Notifications
You must be signed in to change notification settings - Fork 45
Adds the volto.blocks behavior to LRF if plone.volto is installed
#518
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: 8.x
Are you sure you want to change the base?
Conversation
|
@wesleybl thanks for creating this Pull Request and helping to improve Plone! TL;DR: Finish pushing changes, pass all other checks, then paste a comment: To ensure that these changes do not break other parts of Plone, the Plone test suite matrix needs to pass, but it takes 30-60 min. Other CI checks are usually much faster and the Plone Jenkins resources are limited, so when done pushing changes and all other checks pass either start all Jenkins PR jobs yourself, or simply add the comment above in this PR to start all the jobs automatically. Happy hacking! |
|
@mauritsvanrees @davisagli @gforcada It seems the native namespace is causing problems in Plone 6.2. |
During the installation of `plone.app.multilingual`, checks if `plone.volto` is installed. If it is, adds the volto.blocks behavior to LRF.
3d1b5b6 to
917a4df
Compare
|
The problem might be that the |
|
@jenkins-plone-org please run jobs |
|
In fact, it would be necessary to modify all the Plone 6.1 packages that are tested with Plone 6.2 😲 |
|
@jenkins-plone-org please run jobs |
erral
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
|
We should forward-port this to main too @wesleybl |
davisagli
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this makes sense. We do need a PR for the master branch too.
…tup Multilingual Site`.
|
@jenkins-plone-org please run jobs |
During the installation of
plone.app.multilingual, checks ifplone.voltois installed. If it is, adds the volto.blocks behavior to LRF.I didn't add
plone.voltoas a test dependency.Closes plone/Products.CMFPlone#4238