Fix memory leak during unserialize

dktapps · dktapps · commit e501d46c74d0 · 2025-09-11T20:53:52.000+01:00
diff --git a/classes/ByteBufferWriter.cpp b/classes/ByteBufferWriter.cpp
@@ -233,6 +233,8 @@ WRITER_METHOD(__unserialize) {
 	}
 
 	auto object = WRITER_THIS();
+	//would be nice to prevent this from being allocated, but I suppose it's also possible someone could call __unserialize() directly
+	efree(object->writer.buffer);
 
 	writer_init_properties(object, reinterpret_cast<unsigned char*>(Z_STRVAL_P(buffer)), Z_STRLEN_P(buffer), Z_LVAL_P(offset));
 }

Original file line number	Diff line number	Diff line change
`@@ -233,6 +233,8 @@ WRITER_METHOD(__unserialize) {`
`233`	`233`	`}`
`234`	`234`
`235`	`235`	`auto object = WRITER_THIS();`
	`236`	`+ //would be nice to prevent this from being allocated, but I suppose it's also possible someone could call __unserialize() directly`
	`237`	`+ efree(object->writer.buffer);`
`236`	`238`
`237`	`239`	`writer_init_properties(object, reinterpret_cast<unsigned char*>(Z_STRVAL_P(buffer)), Z_STRLEN_P(buffer), Z_LVAL_P(offset));`
`238`	`240`	`}`