Merge pull request #3022 from pnp/dev

December 2020 Release

Author: erwinvanhunen

Binaries/SharePointPnP.Modernization.Framework.dll

@@ -5,7 +5,23 @@ All notable changes to this project will be documented in this file.
 
 The format is based on [Keep a Changelog](http://keepachangelog.com/en/1.0.0/).
 
-## [3.26.2010.0 - unreleased]
+## [3.28.2012.0]
+
+### Added
+
+### Changed
+- Small fixes to README.md
+- Fixed several issues with `Get-PnPSubwebs` and introduced optional parameter `-IncludeRootWeb` to include the rootweb in the results
+- Change in `Copy-PnPFile` which should resolve some issues you may run into when copying files [PR #2796](https://github.com/pnp/PnP-PowerShell/pull/2796)
+- Changed fallback scenario for 'Get-PnPFile' where downloading a file created by a user that no longer exists would try a different technique to download the file. This only worked on English environments though. With this fix, it should work for any language. [PR #2852](https://github.com/pnp/PnP-PowerShell/pull/2852)
+
+### Contributors
+- David Blaszyk [acornsoft]
+- Koen Zomers [koenzomers]
+- Carlos Marins Jr [kadu-jr]
+- Heinrich Ulbricht [heinrich-ulbricht]
+
+## [3.26.2010.0]
 
 ### Added
 - Added `Set-PnPTenant -EnableAutoNewsDigest` option to disable the automatic news digest mails sent to end users [PR #2901](https://github.com/pnp/PnP-PowerShell/pull/2901)

Binaries/SharePointPnP.Modernization.Framework.xml

@@ -656,6 +656,14 @@ protected void Connect()
                 Url = Url.Substring(0, Url.Length - 1);
             }
 
+#if !ONPREMISES
+            if (!PnPConnectionHelper.LegacyMessageShown)
+            {
+                WriteUpdateMessage("\nYou are running the legacy version of PnP PowerShell.\nThis version will be archived soon which means that while staying available, no updates or fixes will be released.\nConsider installing the newer prereleased cross-platform version of PnP PowerShell:\n\nUninstall-Module -Name SharePointPnPPowerShellOnline -AllVersions -Force\nInstall-Module -Name PnP.PowerShell -AllowPrerelease\n\nRead more about the new cross-platform version of PnP PowerShell at\n\nhttps://pnp.github.io/powershell\n\nThe new version of PnP PowerShell will be released as 1.0 in January 2021.\n");
+                PnPConnectionHelper.LegacyMessageShown = true;
+            }
+#endif
+
             PnPConnection connection = null;
 
             var latestVersion = PnPConnectionHelper.GetLatestVersion();

Binaries/release/SharePointPnP.Modernization.Framework.dll

@@ -36,6 +36,7 @@ internal class PnPConnectionHelper
         private static readonly Uri VersionCheckUrl = new Uri("https://raw.githubusercontent.com/pnp/PnP-PowerShell/master/version.txt");
 #endif
         private static bool VersionChecked;
+        internal static bool LegacyMessageShown;
 
 #if !PNPPSCORE
         public static AuthenticationContext AuthContext { get; set; }

Binaries/release/SharePointPnP.Modernization.Framework.xml

@@ -20,17 +20,15 @@ public class RegisterPnPManagementShellAccess : PSCmdlet
         public AzureEnvironment AzureEnvironment = AzureEnvironment.Production;
 
         [Parameter(Mandatory = true)]
+        [Obsolete("This parameter will be ignored")]
         public string SiteUrl;
         protected override void ProcessRecord()
         {
             var endPoint = GenericToken.GetAzureADLoginEndPoint(AzureEnvironment);
-            var uri = new Uri(SiteUrl);
-            var scopes = new[] { $"{uri.Scheme}://{uri.Authority}//.default" };
-
+            
             var application = PublicClientApplicationBuilder.Create(PnPConnection.PnPManagementShellClientId).WithAuthority($"{endPoint}/organizations/").WithRedirectUri("https://login.microsoftonline.com/common/oauth2/nativeclient").Build();
 
-            var result = application.AcquireTokenInteractive(scopes).ExecuteAsync().GetAwaiter().GetResult();
-            result = application.AcquireTokenInteractive(new[] { "https://graph.microsoft.com/.default" }).ExecuteAsync().GetAwaiter().GetResult();
+            application.AcquireTokenInteractive(new[] { "https://graph.microsoft.com/.default" }).ExecuteAsync().GetAwaiter().GetResult();
 
         }
     }

CHANGELOG.md

@@ -70,6 +70,10 @@ public class AddField : PnPWebCmdlet, IDynamicParameters
         [Parameter(Mandatory = false, ParameterSetName = ParameterSet_ADDFIELDBYXMLTOLIST, HelpMessage = "The group name to where this field belongs to")]
         public string Group;
 
+        [Parameter(Mandatory = false, ParameterSetName = ParameterSet_ADDFIELDTOLIST, HelpMessage = "Switch Parameter if this field must be added to all content types")]
+        [Parameter(Mandatory = false, ParameterSetName = ParameterSet_ADDFIELDBYXMLTOLIST, HelpMessage = "Switch Parameter if this field must be added to all content types")]
+        public SwitchParameter AddToAllContentTypes;
+
 #if !ONPREMISES
         [Parameter(Mandatory = false, ParameterSetName = ParameterSet_ADDFIELDTOLIST, HelpMessage = "The Client Side Component Id to set to the field")]
         [Parameter(Mandatory = false, ParameterSetName = ParameterSet_ADDFIELDTOWEB, HelpMessage = "The Client Side Component Id to set to the field")]
@@ -122,6 +126,10 @@ protected override void ExecuteCmdlet()
                         Group = Group,
                         AddToDefaultView = AddToDefaultView
                     };
+
+                    if (AddToAllContentTypes)
+                        fieldCI.FieldOptions |= AddFieldOptions.AddToAllContentTypes;
+
 #if !ONPREMISES
                     if (ClientSideComponentId != null)
                     {

Commands/Base/ConnectOnline.cs

@@ -109,8 +109,9 @@ protected override void ExecuteCmdlet()
                 TargetUrl = UrlUtility.Combine(webServerRelativeUrl, TargetUrl);
             }
 
+            string sourceFolder = SourceUrl.Substring(0, SourceUrl.LastIndexOf('/'));
             Uri currentContextUri = new Uri(ClientContext.Url);
-            Uri sourceUri = new Uri(currentContextUri, SourceUrl);
+            Uri sourceUri = new Uri(currentContextUri, sourceFolder);
             Uri sourceWebUri = Microsoft.SharePoint.Client.Web.WebUrlFromFolderUrlDirect(ClientContext, sourceUri);
             Uri targetUri = new Uri(currentContextUri, TargetUrl);
             Uri targetWebUri = Microsoft.SharePoint.Client.Web.WebUrlFromFolderUrlDirect(ClientContext, targetUri);