fix: resolve flutter analyze issues in hierarchical album picker

- Add missing localization strings (createNewAlbum, createNewSubAlbum, albumName, noAlbumsFound)
- Fix unused imports and missing trailing commas
- Fix null-aware operator usage on non-nullable types
- Fix async function return type for onTap callback
- Update all S.of(context) references to AppLocalizations.of(context)

Co-Authored-By: Claude <[email protected]>

Author: prateekmedia

SUPPORT.md

@@ -1941,5 +1941,9 @@
   "closeBy": "Close",
   "@closeBy": {
     "description": "Appears in the similar images page, to indicate that the images are close in terms of appearance"
-  }
+  },
+  "createNewAlbum": "Create new album",
+  "createNewSubAlbum": "Create new sub-album",
+  "albumName": "Album name",
+  "noAlbumsFound": "No albums found"
 }

mobile/apps/photos/lib/l10n/intl_en.arb

@@ -2,11 +2,9 @@ import 'package:flutter/material.dart';
 import 'package:photos/core/configuration.dart';
 import 'package:photos/generated/l10n.dart';
 import 'package:photos/models/collection/collection.dart';
-import 'package:photos/models/collection/collection_items.dart';
 import 'package:photos/service_locator.dart';
 import 'package:photos/services/collections_service.dart';
 import 'package:photos/theme/ente_theme.dart';
-import 'package:photos/ui/collections/collection_item_widget.dart';
 import 'package:photos/ui/components/buttons/button_widget.dart';
 import 'package:photos/ui/components/models/button_type.dart';
 
@@ -72,7 +70,7 @@ class _HierarchicalAlbumPickerState extends State<HierarchicalAlbumPicker> {
     // Apply additional filters
     if (widget.showOnlyOwnedAlbums) {
       _allCollections = _allCollections
-          .where((c) => c.owner?.id == userId)
+          .where((c) => c.owner.id == userId)
           .toList();
     }
 
@@ -87,11 +85,11 @@ class _HierarchicalAlbumPickerState extends State<HierarchicalAlbumPicker> {
     _allCollections = _allCollections
         .where((c) => c.type != CollectionType.favorites && 
                       c.type != CollectionType.uncategorized &&
-                      !c.isDefaultHidden())
+                      !c.isDefaultHidden(),)
         .toList();
 
     // Sort by name
-    _allCollections.sort((a, b) => a.displayName.compareTo(b.displayName));
+    _allCollections.sort((a, b) => a.displayName.compareTo(b.displayName),);
 
     // Update current level collections
     _updateCurrentLevelCollections();
@@ -103,7 +101,7 @@ class _HierarchicalAlbumPickerState extends State<HierarchicalAlbumPicker> {
       _currentLevelCollections = _allCollections
           .where((c) => c.displayName
               .toLowerCase()
-              .contains(widget.searchQuery!.toLowerCase()))
+              .contains(widget.searchQuery!.toLowerCase()),)
           .toList();
     } else {
       // Show hierarchical view
@@ -330,7 +328,7 @@ class _HierarchicalAlbumPickerState extends State<HierarchicalAlbumPicker> {
           if (_currentLocation != null) {
             // Create sub-album
             newCollection = await CollectionsService.instance
-                .createSubAlbum(_currentLocation!, albumName);
+                .createSubAlbum(albumName, _currentLocation!);
           } else {
             // Create root album
             newCollection = await CollectionsService.instance
@@ -495,7 +493,7 @@ class _HierarchicalAlbumPickerState extends State<HierarchicalAlbumPicker> {
                 labelText: widget.actionButtonText ?? 
                     AppLocalizations.of(context).add,
                 isDisabled: _selectedCollections.isEmpty,
-                onTap: () {
+                onTap: () async {
                   widget.onMultipleAlbumsSelected?.call(
                     _selectedCollections.toList(),
                   );