Skip to content

Address TEMPORARY_RETURN_IGNORED comments for silabs #42111

@gmarcosb

Description

@gmarcosb

Gemini made several critical suggestions in #42089 of which many seem accurate, for example:

critical

Ignoring the return value of GetPrimary802154MACAddress is dangerous. If this function fails, ifp->MacAddress will contain uninitialized data. The subsequent line ifp->hardwareAddress = ByteSpan(ifp->MacAddress, kMaxHardwareAddrSize); will then read from this uninitialized memory, leading to undefined behavior and a potential information leak vulnerability. The error must be checked and propagated.

    ReturnErrorOnFailure(ThreadStackMgrImpl().GetPrimary802154MACAddress(ifp->MacAddress));

Originally posted by @gemini-code-assist[bot] in #42089 (comment)

Metadata

Metadata

Assignees

No one assigned

    Labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions