nodiscard ChipError Batch #19: platform-specific src: Darwin #42083
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request is part of a larger effort to address ignored ChipError return values, focusing on Darwin-specific platform code. The changes are well-executed and fall into a few categories:
- Most changes correctly introduce
TEMPORARY_RETURN_IGNOREDto explicitly acknowledge and suppress warnings for intentionally ignored function return values. This aligns with the goal of making the codebase compliant with[[nodiscard]]attributes. - Several changes are more than just warning suppression; they are valuable code improvements. For instance:
- In
MTROTAImageTransferHandler.mm, a potential bug involving an uninitialized variable being returned has been fixed. - In
MTROperationalCredentialsDelegate.mm, error handling has been added for a previously ignored return value fromreader.ExitContainer(). - In
MTRP256KeypairBridge.mmandMTRSessionResumptionStorageBridge.mm, the code has been refactored to useSetLength()and check its return value, which is cleaner and safer. - In
DnssdImpl.cpp,ChipDnssdStopBrowsenow correctly propagates the error fromctx->Finalize().
- In
All changes are beneficial, improving code correctness, robustness, and clarity. The pull request is a solid contribution to improving the overall quality of the codebase.
|
PR #42083: Size comparison from 4859b93 to 038453f Full report (35 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, efr32, esp32, nrfconnect, nxp, psoc6, qpg, realtek, stm32, telink)
|
bzbarsky-apple
approved these changes
Nov 21, 2025
bzbarsky-apple
requested changes
Nov 21, 2025
|
PR #42083: Size comparison from 4859b93 to 5a0b1fe Full report (6 builds for cc32xx, nrfconnect, realtek, stm32)
|
|
PR #42083: Size comparison from 4859b93 to 1976b8e Full report (35 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, efr32, esp32, nrfconnect, nxp, psoc6, qpg, realtek, stm32, telink)
|
bzbarsky-apple
approved these changes
Nov 21, 2025
|
PR #42083: Size comparison from e123d28 to 4df1081 Full report (35 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, efr32, esp32, nrfconnect, nxp, psoc6, qpg, realtek, stm32, telink)
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Batch 19 of ignored ChipError for #41629
Related issues
#41629
Testing
CI
Readability checklist
The checklist below will help the reviewer finish PR review in time and keep the
code readable:
descriptive
“When in Rome…”
rule (coding style)
See: Pull Request Guidelines